From 04b90a4299a78a1c3c1a6200730e3a905d74f9f6 Mon Sep 17 00:00:00 2001 From: Romaric Pascal Date: Thu, 21 Nov 2024 17:03:05 +0000 Subject: [PATCH] Upgrade test for deprecated LibSass to node-sass@5 This is the first version that can be installed on Github Actions runner without failing thanks to it introducing support for Python 3. https://github.com/sass/node-sass/releases/tag/v5.0.0 Co-authored-by: Brett Kyle Co-authored-by: Owen Jones --- .github/workflows/sass.yaml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/sass.yaml b/.github/workflows/sass.yaml index fe4ee02050..a5f5b78ddf 100644 --- a/.github/workflows/sass.yaml +++ b/.github/workflows/sass.yaml @@ -80,9 +80,9 @@ jobs: run: | ! grep "\$govuk-" .tmp/all.css - # Node Sass v3.7.0 = LibSass v3.5.0 + # Node Sass v5.0.0 = LibSass v3.5.5 lib-sass: - name: LibSass v3.5.0 (deprecated) + name: LibSass v3.5.5 (deprecated) runs-on: ubuntu-latest steps: @@ -93,11 +93,15 @@ jobs: uses: actions/setup-node@v4.1.0 with: cache: npm - node-version: 6 # Node.js 6 supported by Node Sass v3.7.0 + # Node.js 15 is required for the stable support of ES Module + # used when installing `node-sass` + node-version: 15 - name: Install package + # Sass 5.0.0 is the first version that supports Python 3 + # and as such can be built on a GitHub Actions runner run: | - npm install -g node-sass@v3.7.0 + npm install -g node-sass@v5.0.0 node-sass --version - name: Run command