Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to new JSON handling library #145

Open
OlegRa opened this issue Nov 15, 2019 · 4 comments
Open

Switch to new JSON handling library #145

OlegRa opened this issue Nov 15, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@OlegRa
Copy link
Collaborator

OlegRa commented Nov 15, 2019

.NET Core 3.0 and .NET Standard 2.1 provides a new built-in set of classes for fast JSON handling in .NET - this is a new recommended way for handling JSON streams in case of forward-only processing. We can enable this support in a new major SDK release after implementing other .NET Core 3.0 related changes.

@OlegRa OlegRa added the enhancement New feature or request label Nov 15, 2019
@OlegRa OlegRa added this to the SDK 4.0.0 Release milestone Nov 15, 2019
@OlegRa OlegRa self-assigned this Nov 15, 2019
@OlegRa
Copy link
Collaborator Author

OlegRa commented Dec 10, 2019

After analyzing all the pros and cons of this switch and required amount changes in the source code I've decided to postpone such critical change till next major release.

OlegRa added a commit that referenced this issue Dec 10, 2019
OlegRa added a commit that referenced this issue Dec 10, 2019
@OlegRa OlegRa removed this from the SDK 4.0.0 Release milestone Mar 4, 2020
@OlegRa
Copy link
Collaborator Author

OlegRa commented Mar 4, 2020

We have too many features in our deserialization code which heavily depends on JSON.NET library features and now I don't see any real reason for rewriting all this stuff using a new library. I'll not close it but now it has no fixed milestone. If someone will do it or provide real reason why should we implement it I can return back to this task.

@OlegRa OlegRa removed their assignment Mar 7, 2020
@OlegRa
Copy link
Collaborator Author

OlegRa commented Oct 6, 2020

We need this one for issue #144 (at least for the REST part of this issue).

@OlegRa OlegRa self-assigned this Oct 6, 2020
@OlegRa OlegRa added this to the SDK 4.0.0 Release milestone Oct 6, 2020
OlegRa added a commit that referenced this issue Jan 29, 2021
…rd 1.3 support and minimal version of .NET Framework changed from 4.5 to 4.6.1 (both changes required for the upcoming System.Text.Json migration).
@OlegRa OlegRa removed this from the SDK 5.1.x Experimental milestone Jul 26, 2021
@OlegRa
Copy link
Collaborator Author

OlegRa commented Jul 26, 2021

Another good reason to postpone it till .NET 6 release: no-reflection solution via source generators!

@OlegRa OlegRa added this to the SDK 6.0.x NextGen milestone Jul 31, 2021
@OlegRa OlegRa removed this from the SDK 6.0.x Experimental milestone Mar 7, 2022
@OlegRa OlegRa added this to the SDK 7.0.x Experimental milestone Apr 15, 2022
OlegRa added a commit that referenced this issue Oct 26, 2022
* docs: add OlegRa as a contributor for code, doc, and 7 more (#121)
* docs: add ttt733 as a contributor for code, example, and tutorial (#124)
* docs: add ooples as a contributor for code, example, and bug (#125)
* docs: add ElektroMech as a contributor for code (#126)
* docs: add biyimaks as a contributor for code (#127)
* docs: add gjtorikian as a contributor for code (#128)
* docs: add ajit-kolathur as a contributor for code (#129)
* docs: add natehitze as a contributor for code (#130)
* docs: add Hard-Coder05 as a contributor for code (#131)
* docs: add amwsis as a contributor for code (#132)
* docs: add Dav-id as a contributor for doc (#133)
* docs: add shlomikushchi as a contributor for doc (#134)
* docs: add PrometheusUno as a contributor for doc (#135)
* docs: add schmich as a contributor for doc (#136)
* docs: add Ronmenator as a contributor for doc (#137)
* docs: add codebeaulieu as a contributor for code (#138)
* docs: add Xallen79 as a contributor for code (#139)
* docs: add jcjurevis as a contributor for code (#140)
* docs: add koolinoor as a contributor for code, and bug (#141)
* docs: add umitanuki as a contributor for bug, ideas, and 2 more (#142)
* docs: add smartchris84 as a contributor for bug (#143)
* docs: add codebeaulieu as a contributor for bug (#144)
* docs: add mercalli as a contributor for bug (#145)
* docs: add thedudebond as a contributor for bug (#146)
* docs: add biyimaks as a contributor for bug (#147)
* docs: add xutao650 as a contributor for bug (#148)
* docs: add ttt733 as a contributor for bug (#149)
* docs: add Ronmenator as a contributor for bug (#150)
* docs: add sghitch as a contributor for bug (#151)
* docs: add Wingspear as a contributor for bug (#152)
* docs: add jameswhollister as a contributor for bug (#153)
* docs: add DragonMastery as a contributor for bug (#154)
* docs: add apfitzge as a contributor for bug, and ideas (#155)
* docs: add apasumarthi1999 as a contributor for bug (#156)
* docs: add pratttrader as a contributor for bug (#157)
* docs: add tclzcja as a contributor for bug (#158)
* docs: add SavageShade as a contributor for bug (#159)
* docs: add nkoehler as a contributor for bug (#160)
* docs: add camerontbelt as a contributor for bug (#161)
* docs: add adrianbegi as a contributor for bug (#162)
* docs: add FranMaher as a contributor for bug (#163)
* docs: add softwaresalt as a contributor for bug, and ideas (#164)
* docs: add kwcoffee1 as a contributor for bug (#165)
* docs: add gsalaz98 as a contributor for bug (#166)
* docs: add jcjurevis as a contributor for bug, and ideas (#167)
* docs: add thi517 as a contributor for bug (#168)
* docs: add SteveHaudegen as a contributor for bug (#169)
* docs: add samueldonovan1701 as a contributor for bug (#170)
* docs: add jzderadicka as a contributor for bug (#171)
* docs: add aliasgharrajabi as a contributor for bug (#172)
* docs: add Huios as a contributor for bug (#173)
* docs: add rudeGit as a contributor for bug (#174)
* docs: add lgreenlee as a contributor for bug (#175)
* docs: add r-ulak as a contributor for bug (#176)
* docs: add zhorakiev as a contributor for bug, and ideas (#177)
* docs: add shlomikushchi as a contributor for ideas (#178)
* docs: add liftee as a contributor for bug (#179)
* docs: add TonyC1Ward as a contributor for bug (#180)
* docs: add jeffwlandry as a contributor for bug (#181)
* docs: add nbmrao as a contributor for bug (#182)
* docs: add mehtadharmesh as a contributor for bug (#183)
* docs: add Ricbun16 as a contributor for bug (#184)
* docs: add ayushguptacoder as a contributor for bug (#185)
* docs: add opened as a contributor for bug (#186)
* docs: add bizjaya as a contributor for bug (#187)
* docs: add raduistrate as a contributor for bug (#188)
* docs: add woaksie as a contributor for bug (#189)
* docs: add ktrauberman as a contributor for bug (#190)
* docs: add gchudublin as a contributor for bug (#191)
* docs: add mattrobinson3 as a contributor for bug (#192)
* docs: add Tifoid as a contributor for bug (#193)
* docs: add AdsophicSolutions as a contributor for bug, and ideas (#194)
* docs: add waymanapps as a contributor for ideas, and question (#195)
* docs: add tstraus13 as a contributor for bug (#196)
* docs: add matt953 as a contributor for bug, and ideas (#197)
* docs: add YongliangLi as a contributor for bug, and ideas (#198)
* docs: add polymorphicshade as a contributor for bug, and question (#199)
* docs: add nathan-datusarator as a contributor for bug (#200)
* docs: add ManfredLange as a contributor for bug, and ideas (#201)
* docs: add JCloarec as a contributor for bug (#202)
* docs: add jeonnagroup2 as a contributor for bug (#203)
* docs: add IsaackRasmussen as a contributor for bug (#204)
* docs: add matsydoodles as a contributor for bug (#205)
* docs: add natehitze as a contributor for doc (#206)
* docs: add logmd as a contributor for code (#207)
* docs: add tdhatcher as a contributor for bug (#208)
* docs: add TheHumanWithAPlan as a contributor for bug (#209)
* docs: add tcj2001 as a contributor for bug (#210)
* docs: add JasonAr936 as a contributor for bug, and ideas (#211)
* docs: add markns as a contributor for bug (#213)
* docs: add Ilya171 as a contributor for bug (#214)
* docs: add waymanapps as a contributor for financial (#215)

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@OlegRa OlegRa removed this from the SDK 7.0.x LTS milestone Aug 27, 2023
@OlegRa OlegRa added this to the SDK 8.x STS (WIP) milestone Aug 27, 2023
@OlegRa OlegRa removed this from the SDK 8.x WIP milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant