Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Weather forecast to mention and use Dark Sky #2

Open
6 of 7 tasks
alni opened this issue Feb 20, 2019 · 0 comments
Open
6 of 7 tasks

Update Weather forecast to mention and use Dark Sky #2

alni opened this issue Feb 20, 2019 · 0 comments

Comments

@alni
Copy link
Owner

alni commented Feb 20, 2019

Need to update the Weather forecast to use and mention Dark Sky instead of Forecast IO.

  • Rename FORECASTIO AND FORECAST_IO variables (and others with similar names) to DARK_SKY etc.
  • Change API URL to the correct one
  • Change Powered by Forecast to the correct attribution needed now by Dark Sky
  • Update the python-forecastio library to the newest
  • Add support for all current supported languages of Dark Sky with the summaries
  • Update the README to mention Dark Sky instead of Forecast IO
  • Update code comments and strings to mention Dark Sky instead of Forecast IO
alni added a commit that referenced this issue Feb 20, 2019
* Change "FORECAST_IO_" and similar names within some variable names to
  use "DARK_SKY_" instead
* Change API URL to "https://api.darksky.net/forecast/"
* Update some comments and strings (including translations) to mention
  "Dark Sky" instead of "Forecast IO"
* Change endpoint in the WebFrontend of setting the Weather API Key to
  "/darksky_api_key"
  * Change the name and ID of the Weather API Text form field to
    "darksky_api_key"
  * Update "config.js" to use this new endpoint and form field ID
  * Update the link to where to obtain a API Key to point to Dark Sky
* Change Weather API Key property name in "weather/private.json" file
  to "darksky_api_key"
alni added a commit that referenced this issue Feb 24, 2019
* Add support of all currently supported languages by Dark Sky (as of
  2019-02-24)
* Move Icelandic to correct alphabetical order in the list (of the
  language code)
alni added a commit that referenced this issue Feb 24, 2019
After searching all files, this seems to be the last change needed to
mention Dark Sky instead of Forecast IO.
alni added a commit that referenced this issue Mar 5, 2019
Add support of the rest of the Dark Sky languages.

* Checked against the test case files found in the official
  "darkskyapp/translations" repository + tested each one with the API
  to verify that they were actually supported
    * a small number of them returned "invalid/unsupported" value with
      the API (may be because they where recently added the official
      "darkskyapp/translations" repository)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant