Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Forwarding messages bypasses GIF rate limit check #650

Open
amadalusia opened this issue Nov 3, 2024 · 1 comment
Open

[BUG] - Forwarding messages bypasses GIF rate limit check #650

amadalusia opened this issue Nov 3, 2024 · 1 comment

Comments

@amadalusia
Copy link
Member

amadalusia commented Nov 3, 2024

Describe the Bug

Discord has a feature where you can get messages from a host discord channel (say #lobby in SM64 Speedrunning) and then post it to the target discord server (say #general in All Things Linux), you can see an example of this in this message I sent a few days ago. This feature also allows for Tux's GIF rate limit feature to be bypassed.

To Reproduce

Steps to reproduce the behavior:

  1. Go to any chat with Tux where he is configured to have a GIF ratelimit
  2. Send a GIF
  3. Go to another server and send the same GIF regardless of which chatroom
  4. Forward that GIF to the chat with the rate limit
  5. You will see that you have posted 2 GIF's in a row where one is forwarded

image

Expected Behavior

Tux should be able to see the contents of the message and then realise there was 2 GIF's posted at the same time, removing the message automatically as a result of that action.

Environment (please complete the following information)

Skipping this information because this was tested on the production instance of the bot.

  • OS: Ubuntu 20.04
  • Python version: Python 3.12
  • Discord.py version: 2.0.0
  • Tux version: v1.0.0

Additional Context

Asking an eye-witness senior mod to add context

@FarCotton
Copy link
Member

Log of our conversation about the matter in Ticket #1655:

Ticket 1655 .txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants