Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tokenizer + fastchat conv templates #155

Open
natolambert opened this issue Apr 29, 2024 · 2 comments
Open

Migrate to tokenizer + fastchat conv templates #155

natolambert opened this issue Apr 29, 2024 · 2 comments

Comments

@natolambert
Copy link
Collaborator

Realistically, doing our own is a losing battle, let's migrate to something maintained.

@hamishivi
Copy link
Collaborator

There is a start at this here: https://github.com/allenai/open-instruct/blob/main/eval/templates.py#L112
But more formal integrations with fastchat would be good. I think supporting more flexible generation in general is good. E.g. llama 3 with its multiple eos tokens.

@yizhongw
Copy link
Contributor

I came aross this issue when I want to use a different chat template to train models. So, I made this PR. It should support user-defined chat templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants