Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Hinting #58

Open
AndKaminer opened this issue Dec 16, 2023 · 1 comment
Open

Type Hinting #58

AndKaminer opened this issue Dec 16, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AndKaminer
Copy link
Contributor

This goes well with #54, but since technically type hinting isn't part of PEP 8, I pulled it out here. Is type hinting something we want to do? We can check it with something like mypy, which can be automated just like unit testing and flake8. Thoughts?
@MarcCote
Copy link
Collaborator

Type hinting is always great. I like the idea of running mypy but I wouldn't make it as a mandatory check for now.

@MarcCote MarcCote added enhancement New feature or request good first issue Good for newcomers labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarcCote @AndKaminer