Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anode/Cathode on battery appears reversed #50

Open
PeterAJansen opened this issue Aug 8, 2023 · 0 comments
Open

Anode/Cathode on battery appears reversed #50

PeterAJansen opened this issue Aug 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@PeterAJansen
Copy link
Collaborator

I think the anode/cathode on the battery (i.e. source) might be reversed. Here's a log showing that, for the electrical circuit task, a circuit connected as such doesn't work:

  • Battery anode -> wire -> light anode
  • Battery cathode -> wire -> light cathode

But the reverse does appear to work (e.g. anode->cathode instead of anode->anode).

The anode/cathode chaining is required for loads (like the LEDs), but not for the sources (e.g. the battery). Should:

  • Check the simulator and fix this bug
  • Fix any issues w/gold agents and regenerate training data for these tasks

log-power-component.html.pdf

@PeterAJansen PeterAJansen added the bug Something isn't working label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant