Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two PRs are created instead of one: the first one is incorrect, the second one is as expected #656

Open
sglavoie opened this issue Oct 12, 2022 · 5 comments · May be fixed by all-contributors/app#440
Open

Two PRs are created instead of one: the first one is incorrect, the second one is as expected #656

sglavoie opened this issue Oct 12, 2022 · 5 comments · May be fixed by all-contributors/app#440
Assignees
@tenshiAMD
Labels
bug:confirmed bug Something isn't working

Comments

@sglavoie
Copy link

Describe the bug
Two PRs are created instead of one. The first one is irrelevant (wrong username and wrong emoji key) while the second one (which got created after manually closing the first one) gets created correctly.

To Reproduce
Steps to reproduce the behavior: it is unclear how this can be reproduced, but here's a link to the issue where the bug happened.

  1. Add a contributor from a recently closed issue using the exact same phrasing as per the docs: @all-contributors please add @<username> for bug

Expected behavior
A single PR should be created, i.e. this one.

Screenshots
Here, it can be seen that two PRs were created.
Screen Shot 2022-10-12 at 18 10 50

Additional context
Here's what happened for the above screenshot to have gotten to where it is (timezone in CDT):

  1. 5:52pm: the command @all-contributors please add @<username> for bug is invoked from a comment inside an issue.
  2. 5:52pm: the first (incorrect) PR is created.
  3. 5:54pm: the same PR is closed in this comment as it was irrelevant.
  4. 5:54pm: a new PR is created, this one is OK.
  5. 5:55pm: that second PR is merged.
  6. 5:55pm: all-contributors bot added a comment linking to the two PRs it created. It says Please make sure to use valid contribution names, however the original request was for the emoji bug, which is listed in the Emoji Key table.

We have benefited tremendously from all-contributors so far in the above linked repo! Thank you very much! 🙂
@sglavoie sglavoie added the bug Something isn't working label Oct 12, 2022
@tenshiAMD tenshiAMD self-assigned this Oct 13, 2022
@tenshiAMD
Copy link
Member

@sglavoie Thanks for reporting this one. Looks like the issue lies within the comment you made which is a complex one.

Thank you for pointing this out! I've linked to available videos for now, although any PR or issue proposing alternatives will of course be welcome.

all-contributors add @lksmrqrdt for bug

I will check this one later.

@tenshiAMD tenshiAMD linked a pull request Oct 13, 2022 that will close this issue
Open
3 tasks
@tenshiAMD
Copy link
Member

@all-contributors please add @sglavoie for bug

@allcontributors allcontributors bot mentioned this issue Oct 13, 2022
Merged
@allcontributors
Copy link
Contributor

@tenshiAMD

I've put up a pull request to add @sglavoie! 🎉

@tenshiAMD tenshiAMD transferred this issue from all-contributors/all-contributors Oct 13, 2022
@tenshiAMD tenshiAMD transferred this issue from all-contributors/app Oct 13, 2022
@sglavoie
Copy link
Author

Thank you @tenshiAMD! If that helps, here are a couple more cases where I wrote what might be considered a complex comment including a command for all-contributors (those all worked, two of them included an emoji too):

@tenshiAMD
Copy link
Member

Thank you @tenshiAMD! If that helps, here are a couple more cases where I wrote what might be considered a complex comment including a command for all-contributors (those all worked, two of them included an emoji too):

@sglavoie These are valid examples however I found the issue here

Thank you for pointing this out! I've linked to available videos for now, although any PR or issue proposing alternatives will of course be welcome.

since you used the pronoun I've in the sentence, it got parsed as a false positive. Anyways, thanks for the additional info.

@all-contributors all-contributors deleted a comment Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tenshiAMD tenshiAMD

Labels
bug:confirmed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP fix: resolve bugs related to parse comment all-contributors/app
2 participants
@tenshiAMD @sglavoie