Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize contribution types and mappings #429

Open
tenshiAMD opened this issue Oct 4, 2022 · 3 comments
Open

Organize contribution types and mappings #429

tenshiAMD opened this issue Oct 4, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request pinned

Comments

@tenshiAMD
Copy link
Member

It is better to organize types and mappings. I can think of two ways for implementing this one.

  1. Transfer implementation to CLI
  2. Create a separate repo (so it can be highly reusable and customizable in the future)
@tenshiAMD tenshiAMD added enhancement New feature or request pinned labels Oct 4, 2022
@tenshiAMD tenshiAMD self-assigned this Oct 4, 2022
@gr2m
Copy link
Contributor

gr2m commented Oct 6, 2022

I would move the contribution types and mappings into a separate repository, then utilize both in the CLI and the app.

We should also stop using the CLI in the app, and instead extract the code that is shared between them into a library, then use that library in the CLI and the app separately. We discussed this before but I don't know where. Would you be interested in working on that? I'd greatly reduce the complexity and improve maintainability of the project

@tenshiAMD
Copy link
Member Author

@gr2m sure I'm up for it 💪

@tenshiAMD
Copy link
Member Author

We should also stop using the CLI in the app, and instead extract the code that is shared between them into a library, then use that library in the CLI and the app separately.

@gr2m I think it is better if we break down or overview the details so we can track and have better insight. I might need some help with the criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned
Projects
None yet
Development

No branches or pull requests

2 participants