Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 incompatibility for update --comment #130

Open
evilkim opened this issue Feb 24, 2021 · 0 comments
Open

python3 incompatibility for update --comment #130

evilkim opened this issue Feb 24, 2021 · 0 comments

Comments

@evilkim
Copy link

evilkim commented Feb 24, 2021

Easily fixed, here's the patch:

$ git diff
diff --git a/jiracli/processor.py b/jiracli/processor.py
index 9559c77..93ad51b 100644
--- a/jiracli/processor.py
+++ b/jiracli/processor.py
@@ -145,7 +145,7 @@ class UpdateCommand(Command):
             )
         if self.args.issue_comment:
             self.jira.add_comment(
-                self.args.issue, self.args.issue_comment if isinstance(self.args.issue_comment, basestring) else get_text_from_editor()
+                self.args.issue, self.args.issue_comment if isinstance(self.args.issue_comment, str) else get_text_from_editor()
             )
             print_output(self.jira.format_issue(self.jira.get_issue(self.args.issue), comments_only=True))
         elif self.args.issue_priority:

Did I maybe just miss a 2to3 step during install from source?
Would a PR be preferred?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant