From 24b77c01183836ca7a7c56282aee4e59e624902b Mon Sep 17 00:00:00 2001
From: Daniel Bertalan <dani@danielbertalan.dev>
Date: Sun, 7 Jul 2024 16:12:44 +0200
Subject: [PATCH] CI: Remove `esvu` LibJS REPL jobs

As of https://github.com/devsnek/esvu/pull/57, `esvu` now pulls the
LibJS binaries from the Ladybird repo, so these artifacts being created
has no purpose. As far as I can tell, nothing else uses them.

Maybe if the two LibJS versions start going their separate ways enough
to warrant both being available, we could consider re-adding this job.
But no point in using up CI resources for that right now.
---
 .github/workflows/serenity-js-artifacts.yml | 92 ---------------------
 Meta/Lagom/ReadMe.md                        |  1 -
 2 files changed, 93 deletions(-)
 delete mode 100644 .github/workflows/serenity-js-artifacts.yml

diff --git a/.github/workflows/serenity-js-artifacts.yml b/.github/workflows/serenity-js-artifacts.yml
deleted file mode 100644
index c87fb24a9e34b5e..000000000000000
--- a/.github/workflows/serenity-js-artifacts.yml
+++ /dev/null
@@ -1,92 +0,0 @@
-name: Package the js repl as a binary artifact
-
-on: [push]
-
-env:
-  SERENITY_SOURCE_DIR: ${{ github.workspace }}
-  SERENITY_CCACHE_DIR: ${{ github.workspace }}/.ccache
-
-jobs:
-  build-and-package:
-    runs-on: ${{ matrix.os }}
-    if: always() && github.repository == 'SerenityOS/serenity' && github.ref == 'refs/heads/master'
-    strategy:
-      fail-fast: false
-      matrix:
-        os: [ubuntu-22.04]
-        package_type: [Linux-x86_64]
-        os_name: [Linux]
-        include:
-          - os: macos-14
-            package_type: macOS-universal2
-            os_name: macOS
-
-    concurrency:
-      group: ${{ github.workflow }}-${{ matrix.os }}
-      cancel-in-progress: true
-
-    steps:
-      - name: Checkout SerenityOS/serenity
-        uses: actions/checkout@v4
-
-      - name: "Set up environment"
-        uses: ./.github/actions/setup
-        with:
-          os: ${{ matrix.os_name }}
-          arch: 'Lagom'
-
-      - name: Restore Caches
-        uses: ./.github/actions/cache-restore
-        id: 'cache-restore'
-        with:
-          os: ${{ matrix.os_name }}
-          arch: 'Lagom'
-          cache_key_extra: 'LibJS Artifacts'
-          serenity_ccache_path: ${{ env.SERENITY_CCACHE_DIR }}
-          download_cache_path: ${{ github.workspace }}/Build/caches
-
-      - name: Create build directory Ubuntu
-        run: |
-          cmake -S Meta/Lagom -B Build -G Ninja \
-            -DCMAKE_C_COMPILER=gcc-13 \
-            -DCMAKE_CXX_COMPILER=g++-13 \
-            -DBUILD_LAGOM=ON \
-            -DSERENITY_CACHE_DIR=${{ github.workspace }}/Build/caches
-        if: ${{ matrix.os == 'ubuntu-22.04' }}
-        env:
-          CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
-
-      - name: Create build directory macOS
-        run: |
-          # Note: We are using Apple Clang to create Universal binary
-          cmake -S Meta/Lagom -B Build -G Ninja \
-            -DCMAKE_BUILD_TYPE=Release \
-            -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" \
-            -DCMAKE_OSX_DEPLOYMENT_TARGET="11.0" \
-            -DBUILD_LAGOM=ON \
-            -DSERENITY_CACHE_DIR=${{ github.workspace }}/Build/caches
-        if: ${{ matrix.os == 'macos-14' }}
-        env:
-          CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
-
-      - name: Build and package js
-        working-directory: Build
-        run: |
-          ninja js
-          cpack
-        env:
-          CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }}
-
-      - name: Save Caches
-        uses: ./.github/actions/cache-save
-        with:
-          arch: 'Lagom'
-          serenity_ccache_path: ${{ env.SERENITY_CCACHE_DIR }}
-          serenity_ccache_primary_key: ${{ steps.cache-restore.outputs.serenity_ccache_primary_key }}
-
-      - name: Upload js package
-        uses: actions/upload-artifact@v4
-        with:
-          name: serenity-js-${{ matrix.package_type }}
-          path: Build/serenity-js*.tar.gz
-          retention-days: 7
diff --git a/Meta/Lagom/ReadMe.md b/Meta/Lagom/ReadMe.md
index 0c2da9dbc41a975..c1bb17f31a3eb98 100644
--- a/Meta/Lagom/ReadMe.md
+++ b/Meta/Lagom/ReadMe.md
@@ -17,7 +17,6 @@ Lagom is used by the Serenity project in the following ways:
 - [ECMA 262 spec tests](https://serenityos.github.io/libjs-website/test262) for LibJS are run per-commit and tracked on [LibJS website](https://serenityos.github.io/libjs-website/).
 - [Wasm spec tests](https://serenityos.github.io/libjs-website/wasm) for LibWasm are run per-commit and tracked on [LibJS website](https://serenityos.github.io/libjs-website/).
 - [A Wasm LibJS Repl](https://serenityos.github.io/libjs-website/repl) using an Emscripten build of Lagom is hosted on [LibJS website](https://serenityos.github.io/libjs-website/).
-- [The LibJS Repl](../../.github/workflows/serenity-js-artifacts.yml) is built per-commit for Linux and macOS for use by the [esvu](https://github.com/devsnek/esvu) project.
 
 ## Using Lagom in an External Project
 It is possible to use Lagom for your own projects outside of Serenity too!