Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated UIKIT compatibility issue with modern themes using newer UIKIT (YooTheme) #598

Open
spirit8000 opened this issue Apr 25, 2024 · 5 comments

Comments

@spirit8000
Copy link

spirit8000 commented Apr 25, 2024

Hi,

I've been testing a trial license of Weight Tracker on my wife's website which is running the latest version of YooTheme Pro (4.3.12), which ships with UIKIT version 3.19.4. The latest version of Weight Tracker ships with UIKIT 3.9.4 (also ultimately from YooTheme I believe). When trying to display the [wt] shortcode for example under a YooTheme template, all I get is a series of bullet points and a number of errors in developer tools in Chrome (example of error and screenshot below).

If I swap temporarily to one of the built-in themes with Wordpress, all good. I'm aware this plug-in hasn't been tested with the latest version of Wordpress (also in use in my case), however I've already proved the issue I have doesn't relate to this with the theme swapping.

The reason I believe the issue is the mismatch of UIKIT versions is down to the errors, example below. The function "callUpdate", which is present in v3.9.4 (Weight Tracker), is no longer present in 3.19.4, making me wonder if that function and possibly others have been deprecated or changed to something else. Differences noted in the file uikit.min.js .

_uikit.min.js?ver=10.8.1:1 Uncaught TypeError: r[o].callUpdate is not a function
at n (uikit.min.js?ver=10.8.1:1:29009)
at uikit.min.js?ver=10.8.1:1:28827
at It (uikit.min.js?ver=10.8.1:1:13652)
at It (uikit.min.js?ver=10.8.1:1:13710)
at It (uikit.min.js?ver=10.8.1:1:13710)
at It (uikit.min.js?ver=10.8.1:1:13710)
at It (uikit.min.js?ver=10.8.1:1:13710)
at It (uikit.min.js?ver=10.8.1:1:13710)
at As.t.update (uikit.min.js?ver=10.8.1:1:28803)
at ResizeObserver.i (uikit.min.js?ver=10.8.1:1:36292)

This error is generated multiple times over when trying to display [wt] shortcode. Like I said, swap the theme for one of the basic Wordpress built-in ones and it works, I believe because they don't load a newer version of (or possibly any version of) UIKIT first.

I spent quite a long time hacking about with this trying to create a workaround to no avail. On the assumption I'm right about the issue (I could be way off of course! :) )... are there any plans to / is it possible to update the version of UIKIT being used? Or a workaround that I could implement?

I can make a test page available on a staging site with some test creds if it helps anyone to see the issue / errors in realtime.

Thanks to anyone in advance for their time!

Many Thanks,

Scott

Screenshot 2024-04-25 143827

@alicolville
Copy link
Owner

Genuinely sorry for the very slow reply on this! For some reason I never received an email notification.

Let me do some digging!

@alicolville
Copy link
Owner

Could you email me access (if not too late) to a standing environment?

[email protected]

@spirit8000
Copy link
Author

Could you email me access (if not too late) to a standing environment?

[email protected]

Hi,

No worries, thanks for coming back to me, much appreciated. I've since stood down the staging environment I mentioned above but I'll stand another one up and email you creds as we'd still like to progress getting this working. Will try to get this stood up tonight but may fall to tomorrow.

Many Thanks,

Scott

@spirit8000
Copy link
Author

Could you email me access (if not too late) to a standing environment?

[email protected]

That's been sent over to you mate, let me know if you don't receive it. Cheers!

@alicolville
Copy link
Owner

Thanks again for all your help on this. As per the email, I use a "prefixed" version of UIkit so I don't clash ideally with themes (etc) using their own version of it.

I've tried to create a new prefixed version of the latest version of UI kit, but their instructions around doing this using pnpm are wrong (well at least appear to be to me). Previously I did it using their instructions using yarn.

I'll keep trying, but it might not be a quick one! :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

2 participants