Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] SLF4J and Logback version compatibility #304

Open
2 tasks done
michaelkoepf opened this issue Jan 2, 2025 · 0 comments
Open
2 tasks done

[Bug] SLF4J and Logback version compatibility #304

michaelkoepf opened this issue Jan 2, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@michaelkoepf
Copy link
Contributor

michaelkoepf commented Jan 2, 2025 •
edited
Loading

Search before asking

  • I searched in the issues and found nothing similar.

Fluss version

Fluss currently uses SLF4J version 1.7.36. The docs describe how to use Logback with SLF4J but do not point out that newer Logback version are incompatible with SLF4J 1.x. When using Logback >= 1,3, the application start will fail.

Minimal reproduce step

  • Configure Logback >= 1.3 as logging backend
  • Starting Fluss will fail with the following error messages
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
SLF4J: Failed to load class "org.slf4j.impl.StaticMDCBinder".
SLF4J: Defaulting to no-operation MDCAdapter implementation.
SLF4J: See http://www.slf4j.org/codes.html#no_static_mdc_binder for further details.

What doesn't meet your expectations?

Since the SLF4J website has changed and the provided URLs don't really help to troubleshoot the problem, we should add a hint to the doc that users should use Logback <= 1.2.x

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@michaelkoepf michaelkoepf added the bug Something isn't working label Jan 2, 2025
michaelkoepf added a commit to michaelkoepf/fluss that referenced this issue Jan 2, 2025
@michaelkoepf
[docs] Add version compatibility hint for logback
d1f207c 
Issue alibaba#304
@michaelkoepf michaelkoepf mentioned this issue Jan 2, 2025
Closed
michaelkoepf added a commit to michaelkoepf/fluss that referenced this issue Jan 3, 2025
@michaelkoepf
[observability] Add Grafana and Loki as log monitoring stack
56321f4 
- Group logging, metrics, and monitoring into common sidebar menu group ("observability")
- Move monitoring quickstart guide (Prometheus + Grafana) to separate page ("observability quickstart guides")
- Extend monitoring quickstart guide (log monitoring with Loki) + provide new quickstart configuration ZIP archive
- Minor changes and fixes in Flink quickstart guide
- Add version hint for logback in doc

Issue alibaba#295, alibaba#304
@michaelkoepf michaelkoepf mentioned this issue Jan 3, 2025
Open
michaelkoepf added a commit to michaelkoepf/fluss that referenced this issue Jan 3, 2025
@michaelkoepf
[observability] Add Grafana and Loki as log monitoring stack
d5a497b 
- Group logging, metrics, and monitoring into common sidebar menu group ("observability")
- Move monitoring quickstart guide (Prometheus + Grafana) to separate page ("observability quickstart guides")
- Extend monitoring quickstart guide (log monitoring with Loki) + provide new quickstart configuration ZIP archive
- Minor changes and fixes in Flink quickstart guide
- Add version hint for logback in doc

Issue alibaba#295, alibaba#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Add version compatibility hint for logback michaelkoepf/fluss
1 participant
@michaelkoepf