Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve all UNSUPPORTED and UNIMPLEMENTED errors in interactive runtime #4190

Open
zhanglei1949 opened this issue Aug 28, 2024 · 1 comment
Open

Resolve all UNSUPPORTED and UNIMPLEMENTED errors in interactive runtime #4190

zhanglei1949 opened this issue Aug 28, 2024 · 1 comment
Assignees
@zhanglei1949 @liulx20
Labels
stale

Comments

@zhanglei1949
Copy link
Collaborator

Covert all combinations of params and operators in physical plan.
@zhanglei1949 zhanglei1949 mentioned this issue Aug 28, 2024
Merged
zhanglei1949 added a commit that referenced this issue Sep 6, 2024
@zhanglei1949
refactor(interactive): Add error handling for adhoc queries (#4188)
2397f8a 
We Introduce boost::leaf for lightweight error handling in the
Interactive Ad Hoc Query Service.
For each operator, we refactor it returns a `bl::result` value, allowing
the error to be caught and returned at the most outside, i.e.
`adhoc_app.cc`.

In this PR, we only wrap the errors about `UNSUPPORTED` `UNIMPLEMENTED`
and `BAD_REQUET` at operator level. For lower level errors, we still let
it crash.

TBD:
- GAE depends on boost::leaf via vineyard, but we don't want to depend
on vineyard, so a new submodule is introduced, is this ok?

Fix #4189 


We will continue to resolve these `UNSUPPORTED` and `UNIMPLEMENTED`
errors, by covering all combination of all params and operators in
physical plan.
TODO #4190
@github-actions github-actions bot added the stale label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

/cc @zhanglei1949 @liulx20, this issus/pr has had no activity for for a long time, could you folks help to review the status ?
To suppress further notifications,

  • for issues,
    • if it is waiting for further response from the reporter/author, please help to add the label requires-further-info,
    • if you have already started working on it, please add the label work-in-progress to the issue,
    • if this issue requires further designing discussion and not in current plan, or won't be fixed, please add the label requires-further-discussion or wontfix to the issue,
  • for pull requests,
    • if you are still working on it and it is not ready for reviewing, please convert this pull request as draft PR,
    • if you have decided to hold this development on, please add the requires-further-discussion label to the pull request.
      Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhanglei1949 zhanglei1949

@liulx20 liulx20

Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhanglei1949 @liulx20