Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile.games.quickplay.played should be of type number #117

Open
joshuajeschek opened this issue Jun 14, 2023 · 0 comments
Open

Profile.games.quickplay.played should be of type number #117

joshuajeschek opened this issue Jun 14, 2023 · 0 comments

Comments

@joshuajeschek
Copy link

Hi, I think
Profile.games.quickplay.played should be a number. in index.d.ts it is declared as undefined :)
https://github.com/alfg/overwatch-api/blob/cc3188f581c67222b153c3363f6a7755322f33af/api/index.d.ts#LL41C34-L41C34

I didn't want to make a Pull Request since it seemed a bit petty to me, and I wasn't quite sure about your reasoning behind declaring it as undefined
codingbotPark added a commit to codingbotPark/overwatch-api that referenced this issue Nov 20, 2024
@codingbotPark
fix(types): change quickplay.play type to number (alfg#117)
0b41d25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuajeschek