Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loudness Normalization Option Not Working #1

Open
GKid94 opened this issue Jul 10, 2019 · 36 comments
Open

Loudness Normalization Option Not Working #1

GKid94 opened this issue Jul 10, 2019 · 36 comments

Comments

@GKid94
Copy link

GKid94 commented Jul 10, 2019

I still have the loudness normalization when I disable the option

60550594-c91ec380-9d28-11e9-87db-c777829f0076

@alextrv
Copy link
Owner

alextrv commented Jul 11, 2019

The text about normalization in "Stats for nerds" isn't supposed to be changed. The extension changes volume internally. So it doesn't matter what is shown in "Stats for nerds".

@GKid94
Copy link
Author

GKid94 commented Jul 12, 2019

Yes it should, it should only say 100/100 volume without the brackets like this

m0FAUdb

@alextrv
Copy link
Owner

alextrv commented Jul 12, 2019

The information inside parentheses is just a cosmetic thing in this case. If you worry only about that, you shouldn't. As I wrote before the extension changes volume level internally by setting it directly in video tag. If I tried to get rid of this text, the extension would depend on YouTube implementation more than it does now. So if YouTube developers made some changes in their code, there was a higher chance that disabling loudness normalization might not work. It's just more reliable solution.

@GKid94
Copy link
Author

GKid94 commented Jul 13, 2019

So the extension keeps every video at 100/100 volume instead of 100/45 for example but it says in the brackets that the volume was lowered but it's not

@GKid94
Copy link
Author

GKid94 commented Jul 13, 2019

I have the option enabled and it says that the volume is normalized from 9 to 5, and it sounds the same as without the extension

4535345

@ogmkp
Copy link

ogmkp commented Jul 29, 2019

For me, I can hear a normalization difference with or without the checkbox.

@GKid94
Copy link
Author

GKid94 commented Aug 24, 2019

Because the option to disable the loudness normalization is not working, you can double right click on the video and select "show controls" and when you hover the cursor over the sound icon you can see if the video volume is lowered or not

@GKid94
Copy link
Author

GKid94 commented Aug 24, 2019

@alextrv @maxdrash

@alextrv
Copy link
Owner

alextrv commented Aug 24, 2019

Because the option to disable the loudness normalization is not working, you can double right click on the video and select "show controls" and when you hover the cursor over the sound icon you can see if the video volume is lowered or not

It does work. I've made a video to show you.

https://tinyurl.com/y43qjhs4

@GKid94
Copy link
Author

GKid94 commented Aug 24, 2019

@alextrv Try it on more videos

@Onurtag
Copy link

Onurtag commented Aug 25, 2019

It definitely works for me.
You can see the actual volume of the video in the console. With the option off it will be lower on normalized videos.
document.querySelector('video').volume

@GKid94
Copy link
Author

GKid94 commented Aug 25, 2019

@Onurtag Try it on more videos

@Onurtag
Copy link

Onurtag commented Aug 25, 2019

@GKid94 give your non-working example video?

@GKid94
Copy link
Author

GKid94 commented Aug 25, 2019

@Onurtag
Copy link

Onurtag commented Aug 25, 2019

I think you are partly right.
It doesn't work if the page takes too long to load.
The correct volume might have to be continuously applied like this but I don't know how taxing requestanimationframe is or if there is a better way to do it.

I was using an userscript from the above example before I found this extension. https://gist.github.com/Onurtag/28d8826e2f7e369a3fe57bd69bb61f8f
Edit: You can use the same method if you want

@alextrv
Copy link
Owner

alextrv commented Aug 25, 2019

Okay, I found a bug.
Steps to reproduce:

  1. Activate the option "Disable Loudness Normalization"
  2. Open a new tab and go to youtube.com
  3. Search any video and click on it
  4. Double right click on video, select "Show controls" and you will see that it doesn't work.

But if you reload the tab it should work. Probably that's because youtube uses ajax without reloading pages and it breaks the extension. I will try to fix it soon. So workaround for now: just reload the tab.

@GKid94
Copy link
Author

GKid94 commented Sep 2, 2019

@alextrv Can you update the extension the option doesn't work

@GKid94
Copy link
Author

GKid94 commented Sep 13, 2019

@alextrv ?

@GKid94
Copy link
Author

GKid94 commented Feb 10, 2020

The option is still not working

Screenshot_7

@Onurtag
Copy link

Onurtag commented Feb 10, 2020

@GKid94
Copy link
Author

GKid94 commented Feb 11, 2020

How do I add it

@GKid94
Copy link
Author

GKid94 commented Mar 7, 2020

?

@GKid94
Copy link
Author

GKid94 commented May 16, 2020

@Onurtag It doesn't work

@Onurtag
Copy link

Onurtag commented May 16, 2020

@GKid94
It wont show up in the UI. The audio level works correctly.
We all switched to this instead btw
https://gist.github.com/abec2304/2782f4fc47f9d010dfaab00f25e69c8a

@GKid94
Copy link
Author

GKid94 commented May 17, 2020

@Onurtag This is with that script added, the video volume is on 100%

Screenshot_1

@Onurtag
Copy link

Onurtag commented May 17, 2020

Did you read the above comment?
It will NOT show up in the UI.

@GKid94
Copy link
Author

GKid94 commented May 17, 2020

@Onurtag Then how will I know if it's working or not

@GKid94
Copy link
Author

GKid94 commented May 17, 2020

And the script also needs to be updated

@Onurtag
Copy link

Onurtag commented May 17, 2020

Sorry, I didn't know you were deaf. The userscript only fixes the volume not the UI.
I am unfollowing the issue. Take care and goodbye.

@alextrv Sorry for talking in here. I think you can lock this issue because we have a good alternative now.

@GKid94
Copy link
Author

GKid94 commented May 17, 2020

@Onurtag I'm not deaf and I don't hear any difference with that scrip, and you don't have to be rude

@GKid94
Copy link
Author

GKid94 commented May 21, 2020

@Onurtag And also the video page sometimes won't load with that script

@vladaad
Copy link

vladaad commented Sep 27, 2020

@GKid94 both the userscript and the extension work and I can hear the difference. It's either just you not hearing the difference, or something weird on your side.

@GKid94
Copy link
Author

GKid94 commented Sep 27, 2020

@vladaad Yes they work a couple of months later after I added a scrip with Tampermonkey and YouTube changed the algorithm a little

@ogmkp
Copy link

ogmkp commented Nov 1, 2023

This project seems abandoned.

@mara004

This comment was marked as outdated.

@mara004
Copy link

mara004 commented Mar 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants