We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While using AWS Location Service adapter, it should be possible to access the data property of responses using the data accessor.
data
Geocoder::Result::AmazonLocationService stores the response in a @place variable while the base class expects the variable to be named @data
@place
@data
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/amazon_location_service.rb vs https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/base.rb#L6
Geocode results from AWS Location service are correct for the common attributes, but calling data always returns nil.
The text was updated successfully, but these errors were encountered:
Whoops! Thanks for this. The Result class should not define an initialize method. Open to a pull request. (cc @mplewis)
initialize
Sorry, something went wrong.
No branches or pull requests
Expected behavior
While using AWS Location Service adapter, it should be possible to access the data property of responses using the
data
accessor.Actual behavior
Geocoder::Result::AmazonLocationService stores the response in a
@place
variable while the base class expects the variable to be named@data
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/amazon_location_service.rb
vs
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/base.rb#L6
Steps to reproduce
Geocode results from AWS Location service are correct for the common attributes, but calling
data
always returns nil.Environment info
The text was updated successfully, but these errors were encountered: