Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: SDK for Derek #62

Open
alexellis opened this issue Jun 23, 2018 · 3 comments
Open

Suggestion: SDK for Derek #62

alexellis opened this issue Jun 23, 2018 · 3 comments

Comments

@alexellis
Copy link
Owner

Would it be useful to provide Derek as an SDK?

The GitHub auth that we've written has already been useful for the GitHub App in OpenFaaS Cloud and could be useful as a separate package.

Due to forking of Derek over one user not wanting to follow DCO process, would it be advantageous for us to release Derek as an SDK so the functionality can be invoked via other processes such as a regular HTTP server or as suggested in another issue - an AWS Lambda function? #13

If Derek was packaged as an SDK a few things would need to change:

  • secrets would have to be read ahead of time into memory and passed in a configuration object
  • any log.Fatal* lines may need to be removed
  • regression testing would also be needed
  • updates to docs for consumption of SDK
@alexellis
Copy link
Owner Author

I would image this work being done in small increments with each one being released and deployed starting with a configuration object where we load or parse all environmental variables and secrets in one single place then pass that down the stack to any code that needs it.

@alexellis
Copy link
Owner Author

Derek add label: Hacktoberfest

@derek derek bot added the hacktoberfest label Oct 3, 2018
@alexellis
Copy link
Owner Author

This PR should make as few as possible refactorings and stylistic changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant