You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, when using the Shutdown method, I get a panic:
panic: send on closed channel
This is because the removeClient channel is closed before all HTTP handlers got closed.
I am a beginner, but to me it looks like we should never close removeClient.
But it will allow a goroutine leak, since goroutines trying to send on this channel will remain blocked.
I'll try to post a PR.
The text was updated successfully, but these errors were encountered:
Hello, thanks for answering so quickly. In my PR the test reproduces the panic. I'm new to all this git stuff, sorry, I should have committed the test separately from the fix.
Hello, when using the
Shutdown
method, I get a panic:This is because the
removeClient
channel is closed before all HTTP handlers got closed.I am a beginner, but to me it looks like we should never close
removeClient
.But it will allow a goroutine leak, since goroutines trying to send on this channel will remain blocked.
I'll try to post a PR.
The text was updated successfully, but these errors were encountered: