Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Recording.py really need to deepcopy twice? #35

Open
WilCrofter opened this issue Aug 17, 2014 · 0 comments
Open

Does Recording.py really need to deepcopy twice? #35

WilCrofter opened this issue Aug 17, 2014 · 0 comments
Labels

Comments

@WilCrofter
Copy link
Collaborator

Commit 119e4858 fixes a bug causing failure to detect changes to dictionaries, lists, etc., made in response to shell questions.

Replacing self.locals.copy by deepcopy(self.locals) on line 124, Recording.py, was a quick fix but results in 2 separate invocations of deepcopy in the same function, hence is likely redundant and inefficient.

This issue is meant as a reminder to revisit the fix as soon as time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant