From a078c9746bcadbfba8ce8079331a67bcb0bcb3cd Mon Sep 17 00:00:00 2001 From: Tom Hicks Date: Tue, 15 Jul 2014 20:25:26 +0100 Subject: [PATCH 1/2] concat non-HTML lcov reports --- src/reporters/lcov_reporter.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/reporters/lcov_reporter.js b/src/reporters/lcov_reporter.js index b2e0b64..0a26e54 100644 --- a/src/reporters/lcov_reporter.js +++ b/src/reporters/lcov_reporter.js @@ -26,7 +26,7 @@ div.innerText = str; body.appendChild(div); } else { - window._$blanket_LCOV = str; + window._$blanket_LCOV = (window._$blanket_LCOV || '') + str; } }; From c87209b88a7259dc9d9dae698c19731a674e59e0 Mon Sep 17 00:00:00 2001 From: Tom Hicks Date: Tue, 15 Jul 2014 20:26:51 +0100 Subject: [PATCH 2/2] improved function naming and signature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit appendHtml doesn’t necessarily append HTML, so a better name is used. Also, the entire options object is passed through to appendResult, rather than just the boolean. --- src/reporters/lcov_reporter.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/reporters/lcov_reporter.js b/src/reporters/lcov_reporter.js index 0a26e54..8e3759d 100644 --- a/src/reporters/lcov_reporter.js +++ b/src/reporters/lcov_reporter.js @@ -4,7 +4,7 @@ var body = document.body; - var appendHtml = function(filename, data, toHTML) { + var appendResult = function(filename, data, options) { var str = ""; str += 'SF:' + filename + '\n'; @@ -20,7 +20,7 @@ str += 'end_of_record\n'; - if (toHTML) { + if (options.toHTML) { var div = document.createElement('div'); div.className = "blanket_lcov_reporter"; div.innerText = str; @@ -31,15 +31,13 @@ }; blanket.customReporter = function(coverageData, options) { - var toHTML = true; - - if (typeof options !== 'undefined' && typeof options.toHTML !== 'undefined') { - toHTML = options.toHTML; - } + options = options || { + toHTML: true + }; for (var filename in coverageData.files) { var data = coverageData.files[filename]; - appendHtml(filename, data, toHTML); + appendResult(filename, data, options); } };