Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to React 18 API #45

Open
nop33 opened this issue Jan 10, 2023 · 1 comment
Open

Switch to React 18 API #45

nop33 opened this issue Jan 10, 2023 · 1 comment
Labels
🖥 DW Desktop wallet

Comments

@nop33
Copy link
Member

nop33 commented Jan 10, 2023

react-scrollbars-custom is not compatible with React 18. We heavily depend on this library. Thus, even though we have upgraded React to v18, we are still using the React v17 API. Once this lib becomes compatible, we can switch to the React 18 API by simply using the render method of createRoot instead of ReactDom: https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html

I've opened an issue on the library (even though a similar one existed already:

I thought of using react-custom-scrollbars-2 but it's written in JS (no types available).

nop33 referenced this issue in alephium/desktop-wallet Jan 10, 2023
nop33 referenced this issue in alephium/desktop-wallet Jan 11, 2023
nop33 referenced this issue in alephium/desktop-wallet Jan 11, 2023
@nop33
Copy link
Member Author

nop33 commented May 15, 2023

To be completed when #72 is done.

@nop33 nop33 transferred this issue from alephium/desktop-wallet Nov 16, 2023
@nop33 nop33 added the 🖥 DW Desktop wallet label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 DW Desktop wallet
Projects
None yet
Development

No branches or pull requests

1 participant