-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrectly marks non-TU balancer as TU + terminology #15
Comments
Thank you very much for the report. There is definitely some digging to be done for the first blueprint. |
You could have different definitions for universal and UTU, but I think it would be best to discuss this with the rest of the Factorio community. If you do choose something different it should be clear in the program. Edit: I do see this distinction being made on the wiki though, but this Reddit post pocarski calls his UTU balancer universal. If the universal proof assumes that the setup is a belt balancer, then I think you should state this in the UI, as you did with the other proofs. |
Also, since were talking about terminology, does the TU proof require that the setup is a balancer? Or can it also check if non-balancing networks are TU? Such networks have been repeatedly explored in the past (flow router, TU imbalancer, compressor, throughput unlimiter) and are somtimes useful, though if you don't care about the number of splitters, they are trivially easy to design. |
I think the best thing would be to use the terminology of the wiki as that should be the most consistent one.
This is not assumed as it checks that that for all possible inputs and outputs being blocked it is a balancer. This also includes the case in which nothing is blocked.
Cool! I didn't think about these. I think the proof should work nonetheless. Do you mind providing some blueprint that could be added as tests? That would be great! |
I suggest:
True, but emphasis on 'should'. At least 2 of the 4 links in the further-reading section lead to outdated documents (mostly that they state that UTU balancers are impossible), so I think it doesn't fully reflect current usage. Flow routers: They should all be throughput unlimited, but I haven't tested them. The first two links don't have blueprints sadly, and the third is all with express belts, but the TU property should be the same if all the belts are downgraded (assuming undergrounds stay connected). |
First Blueprint:
Test results:
Belt-balancer: Yes
Input-balanced (if belt-balancer): No
TU (if belt-balancer): Yes
Universal: Yes
This blueprint is not TU however; if the two outer input belts receive only 15 item/s and the inner receives the full 30 item/s, the output is still limited to a total of 45 item/s. See https://imgur.com/a/DVMmcIK for a visual.
I think this might be because the balancer uses mixed belts: most are red/fast, but some are yellow/normal.
Second blueprint:
gets results:
Belt-balancer: Yes
Input-balanced (if belt-balancer): No
TU (if belt-balancer): No
Universal: Yes
whereas it has a throughput oscillating between 45 and 60 item/s if the inputs that are next to each other receive 15 item/s each, and the other input receives 30 item/s, so is definitely not universal/UTU. Does the universal proof assume the balancer is TU?
The text was updated successfully, but these errors were encountered: