Fix POM files so that they don't include test fixtures dependencies

Also, ready the gradle files for Gradle 8 by removing deprecated usages, and clean up the `.gitignore` to exclude the `gen` directory properly

Author: alecgrieser

.gitignore

@@ -60,7 +60,7 @@ atlassian-ide-plugin.xml
 protogen/
 /protogen/
 */protogen/*
-*/gen/*
+**/gen/*
 
 *.orig
 /.classpath*

build.gradle

@@ -128,17 +128,17 @@ allprojects {
     task sourcesJar(type: Jar, dependsOn: 'compileJava') {
         description = "Assembles a Jar archive containing the main sources."
         group = JavaBasePlugin.DOCUMENTATION_GROUP
-        appendix = null
-        classifier = "sources"
+        archiveAppendix = null
+        archiveClassifier = "sources"
         from sourceSets.main.allSource
     }
 
     // Create the Javadoc jar
     task javadocJar(type: Jar) {
         description = "Assembles a Jar archive containing the main Javadoc."
         group = JavaBasePlugin.DOCUMENTATION_GROUP
-        appendix = null
-        classifier = "javadoc"
+        archiveAppendix = null
+        archiveClassifier = "javadoc"
         from tasks.javadoc
     }
 

fdb-record-layer-core-shaded/fdb-record-layer-core-shaded.gradle

@@ -48,17 +48,17 @@ createDistribution {dependsOn('shadowJar')}
 task shadedSourcesJar(type: Jar) {
     description = "Assembles a Jar archive containing the main sources."
     group = JavaBasePlugin.DOCUMENTATION_GROUP
-    setArchiveAppendix(null)
-    setArchiveClassifier("sources")
+    archiveAppendix = null
+    archiveClassifier = "sources"
     from project(coreProject).sourceSets.main.allSource
     from project(':fdb-extensions').sourceSets.main.allSource
 }
 
 task shadedJavadocJar(type: Jar) {
     description = "Assembles a Jar archive containing the main Javadoc."
     group = JavaBasePlugin.DOCUMENTATION_GROUP
-    appendix = null
-    classifier = "javadoc"
+    archiveAppendix = null
+    archiveClassifier = "javadoc"
     from project(coreProject).tasks.javadoc
 }
 
@@ -80,6 +80,7 @@ def addDependencies(projectObj, dependenciesNode) {
 }
 
 apply from: rootProject.file('gradle/publishing.gradle')
+
 publishing {
     publications.remove(publishing.publications.library)
 

fdb-record-layer-core/fdb-record-layer-core.gradle

@@ -65,7 +65,7 @@ sourceSets {
 }
 
 task testShadowJar(type: com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar) {
-    classifier = 'standalone-tests'
+    archiveClassifier = 'standalone-tests'
     from sourceSets.main.output
     from sourceSets.test.output
     configurations = [ project.configurations.testRuntimeOnly ]
@@ -79,7 +79,7 @@ task testShadowJar(type: com.github.jengelman.gradle.plugins.shadow.tasks.Shadow
 }
 
 task replJar(type: com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar) {
-    classifier = 'repl'
+    archiveClassifier = 'repl'
     from sourceSets.main.output
     from sourceSets.test.output
     configurations = [ project.configurations.repl ]

fdb-relational-api/fdb-relational-api.gradle

@@ -64,7 +64,6 @@ dependencies {
     testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:${junitVersion}"
 
     testFixturesImplementation "org.assertj:assertj-core:${assertjVersion}"
-    testFixturesImplementation "com.google.protobuf:protobuf-java:${protobufVersion}"
 }
 
 sourceSets {

gradle/publishing.gradle

@@ -56,6 +56,20 @@ publishing {
     publications {
         library(MavenPublication) { publication ->
             from components.java
+
+            // Test fixtures appear to be placing their dependencies in the wrong scope
+            // for maven compilation, which means that their dependencies wing up in the
+            // final project's pom.xml.
+            // See: https://github.com/gradle/gradle/issues/14936
+            // Until this is fixed, skip these configurations to avoid polluting the list of dependencies
+            configurations.each { config ->
+                if (config.name == 'testFixturesApiElements' || config.name == 'testFixturesRuntimeElements') {
+                    components.java.withVariantsFromConfiguration(config) {
+                        skip()
+                    }
+                }
+            }
+
             artifact tasks.sourcesJar
             artifact tasks.javadocJar
             artifact tasks.testJar

gradle/testing.gradle

@@ -234,7 +234,7 @@ tasks.withType(Test).configureEach { task ->
 task testJar(type: Jar, dependsOn: testClasses) {
     group = 'Build'
     description = 'Build a jar file of test classes as an exported artifact'
-    classifier='test'
+    archiveClassifier = 'test'
     from sourceSets.test.output
 }