Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other delivery endpoints #20

Open
petrsvihlik opened this issue Oct 29, 2020 · 7 comments
Open

Support for other delivery endpoints #20

petrsvihlik opened this issue Oct 29, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@petrsvihlik
Copy link
Contributor

Is there a reason why there is support only for the /items endpoint? Was it a deliberate choice or was it just because of the lack of time and it's still the plan to support them at some point?

I can see that for larger projects it could be handy to implement the /items-feed as well. The same goes for the taxonomies... (not to mention other endpoints)

@alanta
Copy link
Owner

alanta commented Oct 29, 2020

There simply was no need for it yet. It definitely makes sense to support other end-points. Maybe it's best to first think about what that would look like in code for people using Kontent.Statiq?

@alanta alanta added the enhancement New feature or request label Oct 29, 2020
@petrsvihlik
Copy link
Contributor Author

I suggest we keep this one open and collect feedback here. I'll definitely have some input myself soon and it was already mentioned by one of our team members too :)

@Simply007
Copy link
Contributor

Single /item endpoint makes sense for me.

Currently, I am using this a a workaround:

new Kontent<Root>(client)
     .WithQuery(
         new EqualsFilter("system.codename", "root"),
         new LimitParameter(1),
         new DepthParameter(3)
     );

@Simply007
Copy link
Contributor

Simply007 commented Nov 27, 2020

This might be a single-use purpose, but /items-feed would help me for bigger datasets for my Kontent - Statiq benchmark.

Or maybe use Paging API for that purpose.

More context here: https://github.com/Kentico/statiq-kontent-collaboration/issues/18

I have datasets for:

  • 512
  • 4092
  • 8192
  • 32768
    items

@alanta
Copy link
Owner

alanta commented Dec 20, 2020

@Simply007 I added very naive support for items feed, this is the result:
image

I'll see about optimizing this a bit.

@alanta
Copy link
Owner

alanta commented Dec 20, 2020

Well, looks like the second run was already a lot faster. I'm assuming that's due to caches being primed from the first run (?). Running the test in a release build shaved off another couple of seconds. I tried profiling but did not see any significant slow downs in the Kontent.Statiq module. Here's the result. I'll push my changes as well.

image

alanta added a commit that referenced this issue Dec 20, 2020
Related to issue #20
@alanta alanta mentioned this issue Dec 20, 2020
5 tasks
alanta added a commit that referenced this issue Dec 28, 2020
Related to issue #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants