Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install multiple python versions #8

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dmitry-shibanov
Copy link

Description:
In scope of this pull request we add logic to install multiple python versions
Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov dmitry-shibanov force-pushed the v-dmshib/install-multiple-python-versions branch from 62fd19c to 69d9d7d Compare December 4, 2022 22:01
Copy link

@e-korolevskii e-korolevskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest always returning an array from the function resolveVersionInput, which will allow us to use more expected behavior in the run function (lines 84-86)

src/setup-python.ts Outdated Show resolved Hide resolved
.github/workflows/test-python.yml Outdated Show resolved Hide resolved
.github/workflows/test-python.yml Outdated Show resolved Hide resolved
Copy link

@MaksimZhukov MaksimZhukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to update the Advanced usage section in the README file

Wrong assumption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants