forked from actions/setup-java
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json for microsoft versions #22
Open
dmitry-shibanov
wants to merge
17
commits into
akv-platform:main
Choose a base branch
from
dmitry-shibanov:add-json-for-microsoft-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add json for microsoft versions #22
dmitry-shibanov
wants to merge
17
commits into
akv-platform:main
from
dmitry-shibanov:add-json-for-microsoft-versions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-korolevskii
approved these changes
Sep 7, 2022
action.yml
Outdated
@@ -59,6 +59,9 @@ inputs: | |||
job-status: | |||
description: 'Workaround to pass job status to post job step. This variable is not intended for manual setting' | |||
default: ${{ job.status }} | |||
token: | |||
description: Used to pull java versions from setup-java. Since there's a default, this is typically not supplied by the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
description: Used to pull java versions from setup-java. Since there's a default, this is typically not supplied by the user. | |
description: `Used to pull java versions from setup-java. Since there's a default, this is typically not supplied by the user` |
marko-zivic-93
approved these changes
Sep 7, 2022
action.yml
Outdated
@@ -59,6 +59,9 @@ inputs: | |||
job-status: | |||
description: 'Workaround to pass job status to post job step. This variable is not intended for manual setting' | |||
default: ${{ job.status }} | |||
token: | |||
description: Used to pull java versions from setup-java. Since there's a default, this is typically not supplied by the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a default value, token is typically not supplied by the user.
vsafonkin
approved these changes
Sep 8, 2022
marko-zivic-93
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe your changes.
Related issue:
Add link to the related issue.
Check list: