Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential version install fix #16

Closed
wants to merge 27 commits into from

Conversation

nikolai-laevskii
Copy link

@nikolai-laevskii nikolai-laevskii commented May 24, 2023

⚠️ I recommend merging installer refactoring before processing this PR.

Description

  • Added LTS runtime installation before requested dotnet installation:
    When dotnet is installed after usage of some other version, install script fails to override dotnet.exe as it appears to be used by a process. Workaround is to pass --skip-unversioned-files flag to the install script and avoid overriding this file altogether. However, to ensure better compatibility and to avoid vulnerability issues, LTS runtime is now installed first, providing up-to-date unversioned files (such as CLI) for further usage.
  • Added E2E tests that check for the problem described in the issue

Options to consider

  1. Running the whole solution on Windows only, as this is the only system where problem appears. This type of change will take minutes to implement, so it's just a matter of preference and how team decides.
  2. Reducing number of additional checks down to 3 (one for each platform). 30 additional checks in E2E tests might be excessive, I left them here just for demonstration. Let me know if you want to leave more than 3.
  3. Use STS runtime instead of LTS.

Related issue:
actions#387

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@nikolai-laevskii nikolai-laevskii changed the base branch from refactor-installer to main May 24, 2023 16:16
@nikolai-laevskii
Copy link
Author

actions#433

@nikolai-laevskii nikolai-laevskii deleted the sequential-version-install-fix branch June 6, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants