forked from actions/setup-dotnet
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequential version install fix #16
Closed
Closed
+603
−461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nikolai-laevskii
force-pushed
the
sequential-version-install-fix
branch
from
May 25, 2023 11:13
500af5b
to
9712d42
Compare
nikolai-laevskii
force-pushed
the
sequential-version-install-fix
branch
from
May 25, 2023 11:28
9712d42
to
46ada94
Compare
nikolai-laevskii
force-pushed
the
sequential-version-install-fix
branch
from
May 30, 2023 11:37
46ada94
to
3d00141
Compare
nikolai-laevskii
requested review from
dmitry-shibanov,
MaksimZhukov and
IvanZosimov
and removed request for
dmitry-shibanov
May 31, 2023 08:05
nikolai-laevskii
force-pushed
the
sequential-version-install-fix
branch
from
May 31, 2023 09:22
3d00141
to
faa708d
Compare
MaksimZhukov
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dotnet is installed after usage of some other version, install script fails to override dotnet.exe as it appears to be used by a process. Workaround is to pass
--skip-unversioned-files
flag to the install script and avoid overriding this file altogether. However, to ensure better compatibility and to avoid vulnerability issues, LTS runtime is now installed first, providing up-to-date unversioned files (such as CLI) for further usage.Options to consider
Related issue:
actions#387
Check list: