Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with native gRPC client #3

Open
alexmt opened this issue Mar 20, 2023 · 0 comments
Open

Compatibility with native gRPC client #3

alexmt opened this issue Mar 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@alexmt
Copy link
Contributor

alexmt commented Mar 20, 2023

Proposal

Generate REST client that implements native gRPC client interface.

Motivation

The generated API client is great. However, it is slightly different from the native gRPC client interface.

  • grpc-gateway client interface:
// GreeterGatewayClient is the interface for Greeter service client.
type GreeterGatewayClient interface {
	// Sends a greeting
	SayHello(context.Context, *HelloRequest) (*HelloReply, error)
}
  • native grpc client
type GreeterClient interface {
	// Sends a greeting
	SayHello(context.Context, *HelloRequest,  ...grpc.CallOption) (*HelloReply, error)
}

If grpc-gateway client uses the same interface as native gRPC then it can be used as a drop-in replacement, making adoption much easier.

@alexmt alexmt added the enhancement New feature or request label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant