Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to Akka HTTP based AWS connector #3

Open
rkuhn opened this issue Jan 29, 2016 · 7 comments
Open

switch to Akka HTTP based AWS connector #3

rkuhn opened this issue Jan 29, 2016 · 7 comments
Labels
enhancement

Comments

@rkuhn
Copy link
Contributor

rkuhn commented Jan 29, 2016

No description provided.

@rkuhn rkuhn added this to the 1.0 milestone Jan 29, 2016
@rkuhn rkuhn removed this from the 1.0 milestone Feb 9, 2016
@rkuhn
Copy link
Contributor Author

rkuhn commented Feb 10, 2016

This is not immediately necessary, the cost with the current approach is that many threads (hundreds) are needed for the AWS client library but it works well enough.

@ktoso
Copy link
Member

ktoso commented Feb 10, 2016

For future reference, request signing will be needed then, and that @johanandren has in one of his projects already :)

@rmmeans
Copy link
Contributor

rmmeans commented Feb 17, 2016

+1 for such an enhancement! Have a play app currently using dynamo and had the same struggle with the AWS java SDK, ended up signing everything and falling back to the PlayWS library instead. Is the prior work from @johanandren public reference by chance?

@brianmowen brianmowen mentioned this issue Nov 22, 2016
Closed
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 23, 2017
@markus1189
Switch to Akka HTTP based AWS connector
bf6af77 
Removes AWS SDK
Adds Alpakka as new Client
To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
Introduces settings for Backoff and Retries instead of magic numbers.
This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 23, 2017
@markus1189
Switch to Akka HTTP based AWS connector
77d1bde 
Removes AWS SDK
Adds Alpakka as new Client
To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
Introduces settings for Backoff and Retries instead of magic numbers.
Refactored Describe from Type Class to pattern matching for better testablility and simpler code
This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 23, 2017
@markus1189
Switch to Akka HTTP based AWS connector
6aade2d 
Removes AWS SDK
Adds Alpakka as new Client
To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
Introduces settings for Backoff and Retries instead of magic numbers.
Refactored Describe from Type Class to pattern matching for better testablility and simpler code
This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 23, 2017
@markus1189
Switch to Akka HTTP based AWS connector
48709d0 
Removes AWS SDK
Adds Alpakka as new Client
To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
Introduces settings for Backoff and Retries instead of magic numbers.
Refactored Describe from Type Class to pattern matching for better testablility and simpler code
This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 23, 2017
@markus1189
Switch to Akka HTTP based AWS connector
16d4d6f 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 23, 2017
@markus1189
Switch to Akka HTTP based AWS connector
03b0619 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
0e38c1e 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
2bc2e71 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
2cb4ab8 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
eecb16d 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
845b2e2 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
0de0819 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
63c04b5 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 24, 2017
@markus1189
Switch to Akka HTTP based AWS connector
9af838d 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
@christianuhlcc christianuhlcc mentioned this issue Mar 24, 2017
Closed
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 25, 2017
@markus1189
Switch to Akka HTTP based AWS connector
15370c1 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Mar 28, 2017
@markus1189
Switch to Akka HTTP based AWS connector
ba74d70 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
christianuhlcc pushed a commit to christianuhlcc/akka-persistence-dynamodb that referenced this issue Apr 21, 2017
@markus1189
Switch to Akka HTTP based AWS connector
b13d944 
- Removes AWS SDK
- Adds Alpakka as new Client
- To perform a clean change we refactored the DynamoDBJournal so that the Helper can be replaced in isolation.
- Introduces settings for Backoff and Retries instead of magic numbers.
- Refactored Describe from Type Class to pattern matching for better testablility and simpler code
- Removed no longer used AWS Client Settings
- Removed Documentation of Threading Issue from Readme
- Bump Version to 1.1.0

This fixes issue akka#3
@joost-de-vries
Copy link
Contributor

This requirement will be much much easier to implement once the Aws Sdk v2 becomes available. V2 will support plugging in a different Http client. And it will support CompletableFuture. So perhaps it's worth it to wait for V2...

@alexmnyc
Copy link

any updates on porting it to aws sdk v2?

@alexmnyc
Copy link

any chance to support akka 2.5.x?

@raboof
Copy link
Member

raboof commented Dec 16, 2018

@alexmnyc the AWS SDK v2 was recently released, but I'm not aware of anyone having started porting this plugin to use it.

Even though the plugin is built against Akka 2.4.20, because Akka is careful about binary compatibility the plugin likely works fine with Akka 2.5.x. Did you encounter any problems?

@coreyoconnor coreyoconnor mentioned this issue Sep 19, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ktoso @raboof @rkuhn @alexmnyc @joost-de-vries @rmmeans