Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode's icon #2135

Closed
KD-MM2 opened this issue Sep 19, 2024 · 3 comments
Closed

Dark mode's icon #2135

KD-MM2 opened this issue Sep 19, 2024 · 3 comments
Labels
✨ Feature A feature you'd like to be added ⛔ Wont Fix This will not be worked on

Comments

@KD-MM2
Copy link

KD-MM2 commented Sep 19, 2024

Description

Currently the icon for an app can only be set to one, this will default to one icon for both light and dark mode, some icons (for example AFFiNE - from selfh.st's icon) are black and setting a light icon for dark mode and vice versa makes the interface unsightly.
Screenshot from 2024-09-19 23-49-08

Priority

Low (Nice-to-have)

@KD-MM2 KD-MM2 added the ✨ Feature A feature you'd like to be added label Sep 19, 2024
Copy link

Hi 👋. Thank you for submitting your first issue to Homarr. Please ensure that you've provided all nessesary information. You can use the three dots > Edit button to update your post with additional images and information. Depending on the current volume of requests, the team should get in conact with you shortly.

@manuel-rw
Copy link
Collaborator

manuel-rw commented Sep 20, 2024

Hi, icons should be visible in both dark and light modes. If this is not the case, the author of the icons should reconsider their colors. Most icons will be colorful by default for this exact reason. The additional complexity (background loading, cache, ...) in Homarr is not worth the change.
As a workaround, you could...

@manuel-rw manuel-rw added the ⛔ Wont Fix This will not be worked on label Sep 20, 2024
@manuel-rw manuel-rw closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
@SeDemal
Copy link
Collaborator

SeDemal commented Sep 21, 2024

Side note, Homarr V1 supports a monochrome library of icons that you can color the way you want, straight in the URL.
(And if you want to use that url to just download the icon for local storage, all the power to you)

A little more info here: homarr-labs/homarr ->#1118

If you're willing to test it out for us, join the insiders and early adopters on our Discord :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature A feature you'd like to be added ⛔ Wont Fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants