-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SponsorBlock not skipping sponsors the first time. #1820
Comments
I have the same problem |
Same here |
Browser? Is it always, sometimes? Or rarely? List extensions or userscripts installed |
Every single time on first video open. Extensions:
I don't think I have any userscripts. Running
|
Firefox Youtube-related extensions:
Also, when this happens, I can make the extension skip the segment (when I'm currently watching that segment) by hitting the refresh segments button. Enabling/disabling skipping doesn't help. Also, if I go back the video before the segment starts, then it skips. |
Can you send your enhancer settings |
|
I'm not getting any sponsorblock errors and even if I disable everything it's still not skipping. |
same no errors |
Can you go to options -> import/export -> copy debug info |
Same issue for me. Firefox, Linux, only youtube extension is "Tweaks for Youtube", I don't run Enhancer or anything else like that. I do run DeArrow though |
Is there a specific pattern to when it appears. Is it when opening videos in new tabs with the middle mouse button? Or when clicking videos from the homepage? Or only when directly visiting a video from a URL in the browser. |
most of the times I open videos in new tab. This tends to break some Youtube addons now that I think about it |
I've been running into this issue very frequently recently. I know it happens when I CTRL+click to open a video in a new tab as I usually do, but I haven't thoroughly tested other cases.
|
Perfect, I think my fix will work then, thanks! |
I always open my videos via Middle Mouse Click to a new tab, as I use Inoreader to manage my subscriptions |
Let me know if it is still happening in 5.4.15 |
@ajayyy yep it's still happening in 5.4.15 Here is debug info: Click to open{
"debug": {
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36",
"platform": "Win32",
"language": "en-NL",
"extensionVersion": "5.4.15"
},
"config": {
"autoSkipOnMusicVideosUpdate": true,
"categoryPillUpdate": true,
"categorySelections": [
{
"name": "sponsor",
"option": 2
},
{
"name": "intro",
"option": 2
},
{
"name": "interaction",
"option": 2
},
{
"name": "selfpromo",
"option": 2
},
{
"name": "preview",
"option": 2
},
{
"name": "poi_highlight",
"option": 1
},
{
"name": "music_offtopic",
"option": 2
},
{
"name": "exclusive_access",
"option": 0
},
{
"name": "chapter",
"option": 0
}
],
"chapterCategoryAdded": true,
"dontShowNotice": false,
"hideDiscordLaunches": 4,
"invidiousInstances": 23,
"isVip": false,
"manualSkipOnFullVideo": false,
"minutesSaved": 10531.90994811656,
"payments": {
"chaptersAllowed": true,
"freeAccess": true,
"lastCheck": 1664869014594,
"licenseKey": null
},
"permissions": {
"chapter": true,
"exclusive_access": true,
"filler": true,
"interaction": true,
"intro": true,
"music_offtopic": true,
"outro": true,
"poi_highlight": true,
"preview": true,
"selfpromo": true,
"sponsor": true
},
"previewCategoryUpdate": true,
"renderSegmentsAsChapters": false,
"showChapterInfoMessage": false,
"showDeArrowPromotion": false,
"showPopupDonationCount": 5,
"showSegmentNameInChapterBar": true,
"showUpsells": false,
"showZoomToFillError": false,
"showZoomToFillError2": false,
"skipCount": 17468,
"sponsorTimesContributed": 42,
"submissionCountSinceCategories": 42,
"unsubmittedSegments": {
"-Ry7SVwnsEA": [
{
"UUID": null,
"category": "chooseACategory",
"segment": [
5.56983
]
}
],
"DIHy6J23FVk": [
{
"UUID": null,
"actionType": "skip",
"category": "chooseACategory",
"segment": [
479.878373
],
"source": 1
}
],
"FBQaV0JidZs": [
{
"UUID": null,
"category": "sponsor",
"segment": [
573.864059,
622.853319
]
}
],
"INjgdhFzIEY": [
{
"UUID": "jCGU1LUrq19z1whmfs781ByRHzEygF46fijL",
"actionType": "skip",
"category": "sponsor",
"description": "",
"segment": [
6.514,
82.858
],
"source": 1
}
],
"JaD_Ze-544E": [
{
"UUID": null,
"category": "chooseACategory",
"segment": [
26.746552
],
"source": 1
}
],
"PUKfmMH157U": [],
"QeyQ1SNd6fQ": [
{
"UUID": "tb3TtdBNz2alkpVInObJWjxugME224nB0Xri",
"actionType": "skip",
"category": "sponsor",
"segment": [
93.972,
149.32
],
"source": 1
}
],
"UK-lGSYKaaM": [
{
"UUID": null,
"actionType": "skip",
"category": "chooseACategory",
"segment": [
0,
51.222887
],
"source": 1
}
],
"YZ96Ay7YDIg": [
{
"UUID": null,
"category": "chooseACategory",
"segment": [
1.81335
]
}
],
"_h8-SBO-RKo": [
{
"UUID": null,
"category": "chooseACategory",
"segment": [
29.700321
]
}
],
"jfQAAmz59bk": [
{
"UUID": "iWEyUmNqe8BfJaL3GRwQVNNaO1gbnpGLPERp",
"actionType": "skip",
"category": "sponsor",
"description": "",
"segment": [
0,
17.485
],
"source": 1
}
],
"lUXz_OF-cIc": [
{
"UUID": "DT01SX99RAgVFCMYobMSX35kpBKWHhFThez9",
"actionType": "skip",
"category": "sponsor",
"description": "",
"segment": [
148.485,
200.71
],
"source": 1
}
],
"pJIrdzhsWRM": [
{
"UUID": null,
"category": "chooseACategory",
"segment": [
3.565164
]
}
],
"qgMRLQGK3R8": [
{
"UUID": "gSZMBUQbILx2LlMWrP1u7IJuNs0drwpUBMRU",
"actionType": "skip",
"category": "sponsor",
"segment": [
0,
6.236
],
"source": 1
}
],
"w5EjHfQ6r40": [
{
"UUID": null,
"actionType": "skip",
"category": "chooseACategory",
"segment": [
1491.125
],
"source": 1
}
]
},
"defaultCategory": "chooseACategory",
"whitelistedChannels": 0,
"forceChannelCheck": false,
"showTimeWithSkips": true,
"disableSkipping": false,
"muteSegments": true,
"fullVideoSegments": true,
"fullVideoLabelsOnThumbnails": true,
"trackViewCount": true,
"trackViewCountInPrivate": true,
"trackDownvotes": true,
"noticeVisibilityMode": 3,
"hideVideoPlayerControls": false,
"hideInfoButtonPlayerControls": false,
"hideDeleteButtonPlayerControls": false,
"hideUploadButtonPlayerControls": false,
"hideSkipButtonPlayerControls": false,
"hideDiscordLink": false,
"supportInvidious": false,
"serverAddress": "Default server address",
"minDuration": 0,
"skipNoticeDuration": 4,
"audioNotificationOnSkip": false,
"checkForUnlistedVideos": false,
"testingServer": false,
"refetchWhenNotFound": true,
"ytInfoPermissionGranted": false,
"allowExpirements": true,
"showDonationLink": true,
"showNewFeaturePopups": true,
"donateClicked": 0,
"autoHideInfoButton": true,
"autoSkipOnMusicVideos": false,
"scrollToEditTimeUpdate": false,
"darkMode": true,
"showCategoryGuidelines": true,
"showCategoryWithoutPermission": false,
"useVirtualTime": true,
"showSegmentFailedToFetchWarning": true,
"allowScrollingToEdit": true,
"deArrowInstalled": false,
"categoryPillColors": {},
"skipKeybind": {
"key": "Enter"
},
"startSponsorKeybind": {
"key": ";"
},
"submitKeybind": {
"key": "'"
},
"nextChapterKeybind": {
"key": "ArrowRight",
"ctrl": true
},
"previousChapterKeybind": {
"key": "ArrowLeft",
"ctrl": true
},
"colorPalette": {
"red": "#780303",
"white": "#ffffff",
"locked": "#ffc83d"
},
"barTypes": {
"preview-chooseACategory": {
"color": "#ffffff",
"opacity": "0.7"
},
"sponsor": {
"color": "#00d400",
"opacity": "0.7"
},
"preview-sponsor": {
"color": "#007800",
"opacity": "0.7"
},
"selfpromo": {
"color": "#ffff00",
"opacity": "0.7"
},
"preview-selfpromo": {
"color": "#bfbf35",
"opacity": "0.7"
},
"exclusive_access": {
"color": "#008a5c",
"opacity": "0.7"
},
"interaction": {
"color": "#cc00ff",
"opacity": "0.7"
},
"preview-interaction": {
"color": "#6c0087",
"opacity": "0.7"
},
"intro": {
"color": "#00ffff",
"opacity": "0.7"
},
"preview-intro": {
"color": "#008080",
"opacity": "0.7"
},
"outro": {
"color": "#0202ed",
"opacity": "0.7"
},
"preview-outro": {
"color": "#000070",
"opacity": "0.7"
},
"preview": {
"color": "#008fd6",
"opacity": "0.7"
},
"preview-preview": {
"color": "#005799",
"opacity": "0.7"
},
"music_offtopic": {
"color": "#ff9900",
"opacity": "0.7"
},
"preview-music_offtopic": {
"color": "#a6634a",
"opacity": "0.7"
},
"poi_highlight": {
"color": "#ff1684",
"opacity": "0.7"
},
"preview-poi_highlight": {
"color": "#9b044c",
"opacity": "0.7"
},
"filler": {
"color": "#7300FF",
"opacity": "0.9"
},
"preview-filler": {
"color": "#2E0066",
"opacity": "0.7"
}
}
}
} |
@Iaotle are there errors in the console? |
None related to Sponsorblock. Just errors from adblocker and the like. You can contact me on discord if u wanna debug it at some point, same username. |
I'm getting this on 5.4.15 as well. I open videos with middle click almost exclusively, but I just had it happen on a video where I didn't. No error in console, and I do see the sponsor spot, but I only check when I notice its not skipping. Debug: Click me{
"debug": {
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0",
"platform": "Win32",
"language": "en-US",
"extensionVersion": "5.4.15"
},
"config": {
"autoSkipOnMusicVideosUpdate": true,
"chapterCategoryAdded": true,
"invidiousInstances": 15,
"categorySelections": [
{
"name": "sponsor",
"option": 2
},
{
"name": "exclusive_access",
"option": 0
},
{
"name": "chapter",
"option": 0
}
],
"showZoomToFillError2": false,
"skipCount": 4,
"muteSegments": false,
"minutesSaved": 3.062949999999982,
"dontShowNotice": true,
"isVip": false,
"permissions": {
"sponsor": true,
"selfpromo": true,
"exclusive_access": true,
"interaction": true,
"intro": true,
"outro": true,
"preview": true,
"music_offtopic": true,
"filler": true,
"poi_highlight": true,
"chapter": false
},
"unsubmittedSegments": {},
"defaultCategory": "chooseACategory",
"renderSegmentsAsChapters": false,
"whitelistedChannels": 0,
"forceChannelCheck": false,
"sponsorTimesContributed": 0,
"submissionCountSinceCategories": 0,
"showTimeWithSkips": true,
"disableSkipping": false,
"fullVideoSegments": true,
"fullVideoLabelsOnThumbnails": true,
"manualSkipOnFullVideo": false,
"trackViewCount": true,
"trackViewCountInPrivate": true,
"trackDownvotes": true,
"noticeVisibilityMode": 3,
"hideVideoPlayerControls": false,
"hideInfoButtonPlayerControls": false,
"hideDeleteButtonPlayerControls": false,
"hideUploadButtonPlayerControls": false,
"hideSkipButtonPlayerControls": false,
"hideDiscordLaunches": 0,
"hideDiscordLink": false,
"supportInvidious": false,
"serverAddress": "Default server address",
"minDuration": 0,
"skipNoticeDuration": 4,
"audioNotificationOnSkip": false,
"checkForUnlistedVideos": false,
"testingServer": false,
"refetchWhenNotFound": true,
"ytInfoPermissionGranted": false,
"allowExpirements": true,
"showDonationLink": true,
"showPopupDonationCount": 0,
"showUpsells": true,
"showNewFeaturePopups": true,
"donateClicked": 0,
"autoHideInfoButton": true,
"autoSkipOnMusicVideos": false,
"scrollToEditTimeUpdate": false,
"categoryPillUpdate": false,
"showChapterInfoMessage": true,
"darkMode": true,
"showCategoryGuidelines": true,
"showCategoryWithoutPermission": false,
"showSegmentNameInChapterBar": true,
"useVirtualTime": true,
"showSegmentFailedToFetchWarning": true,
"allowScrollingToEdit": true,
"deArrowInstalled": false,
"showDeArrowPromotion": true,
"categoryPillColors": {},
"skipKeybind": {
"key": "Enter"
},
"startSponsorKeybind": {
"key": ";"
},
"submitKeybind": {
"key": "'"
},
"nextChapterKeybind": {
"key": "ArrowRight",
"ctrl": true
},
"previousChapterKeybind": {
"key": "ArrowLeft",
"ctrl": true
},
"payments": {
"licenseKey": null,
"lastCheck": 0,
"lastFreeCheck": 0,
"freeAccess": false,
"chaptersAllowed": false
},
"colorPalette": {
"red": "#780303",
"white": "#ffffff",
"locked": "#ffc83d"
},
"barTypes": {
"preview-chooseACategory": {
"color": "#ffffff",
"opacity": "0.7"
},
"sponsor": {
"color": "#00d400",
"opacity": "0.7"
},
"preview-sponsor": {
"color": "#007800",
"opacity": "0.7"
},
"selfpromo": {
"color": "#ffff00",
"opacity": "0.7"
},
"preview-selfpromo": {
"color": "#bfbf35",
"opacity": "0.7"
},
"exclusive_access": {
"color": "#008a5c",
"opacity": "0.7"
},
"interaction": {
"color": "#cc00ff",
"opacity": "0.7"
},
"preview-interaction": {
"color": "#6c0087",
"opacity": "0.7"
},
"intro": {
"color": "#00ffff",
"opacity": "0.7"
},
"preview-intro": {
"color": "#008080",
"opacity": "0.7"
},
"outro": {
"color": "#0202ed",
"opacity": "0.7"
},
"preview-outro": {
"color": "#000070",
"opacity": "0.7"
},
"preview": {
"color": "#008fd6",
"opacity": "0.7"
},
"preview-preview": {
"color": "#005799",
"opacity": "0.7"
},
"music_offtopic": {
"color": "#ff9900",
"opacity": "0.7"
},
"preview-music_offtopic": {
"color": "#a6634a",
"opacity": "0.7"
},
"poi_highlight": {
"color": "#ff1684",
"opacity": "0.7"
},
"preview-poi_highlight": {
"color": "#9b044c",
"opacity": "0.7"
},
"filler": {
"color": "#7300FF",
"opacity": "0.9"
},
"preview-filler": {
"color": "#2E0066",
"opacity": "0.7"
}
}
}
} |
can you install this (disable the original) and try to reproduce the issue. Then send me the console logs along and the order of videos you clicked https://github.com/ajayyy/SponsorBlock/wiki/Chromium-Unpacked-Install#install-the-extension You can email it if you want (dev @ ajay. app) |
Unfortunately, I cannot. Chrome does not work for me, videos don't load at all. Its not related to SponsorBlock, I have no idea why it won't load and have very little interest in fixing it. I use Firefox as my main browser, if you can give me a debug build for Firefox I can test it. |
@staridiot You can load this in Firefox as well https://github.com/ajayyy/SponsorBlock/wiki/Testing-a-Pull-Request#installing |
Sorry about that, I have updated the builds in that comment. It was pointing to my debug server and not the main one |
I was able to reproduce it with the debug build, I don't know if it matters, but I middle mouse clicked multiple videos from https://www.youtube.com/feed/subscriptions and let them load in the background, then went through them and found the first one with a sponsor segment (https://www.youtube.com/watch?v=o69WALtFpI0) and watched (at 2x speed, maybe important?) through until the sponsor section. The sponsor section was properly marked on the timeline, but wasn't skipped once it entered the section. Manually opening the SB panel and refreshing the segments made SB properly skip it. Here's the log, there is also a CSP violation error that seem to stem from SB so I included that as well.
|
@Hakkin do you use videospeed extension? |
For what it's worth this happens to me too and I watch at 2x speed with the
extension tweaks for YouTube
…On Sat, 19 Aug 2023, 2:31 pm Ajay Ramachandran, ***@***.***> wrote:
Sorry about that, I have updated the builds in that comment
—
Reply to this email directly, view it on GitHub
<#1820 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFLTC55VL3N2F5EGOAP4NDXWC5Z3ANCNFSM6AAAAAA3HNJ3CA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
The YouTube extensions I have are "Enhancer for YouTube", "HyperChat", "ytcFilter" and "YouTube Livestreams Theater Mode". Enhancer for YouTube offers higher than 2x playback, but I rarely go above 2x, and I change the speed using YouTube's keyboard shortcut (Shift+.) rather than Enhancer's (Ctrl+Mousewheel). |
I also just reproduced this with all those extensions disabled though, only SponsorBlock + YouTube's built-in 2x playback. |
@Hakkin thanks for being so specific on when the skip didn't happen in the logs! Could you try this again with this build with even more logging? |
@ajayyy Here are the logs, from https://www.youtube.com/watch?v=3rjnRJlJyAY
|
It definitely seems to have something to do with the playback speed. I was testing with this video: https://www.youtube.com/watch?v=TCJrC9KRnrQ |
I regularly encounter this, I also watch every video sped-up and change playback rates live, usually with Video Speed Controller (Chrome) keyboard shortcuts. |
Can you try out this build and see if you can reproduce the issue? I added code to check every 2 seconds if the playback rate has changed incase for some reason the playbackChanged browser event isn't being sent. If it still fails, can you send the logs again? EDIT: Actually I need to change one thing sorry will post another comment |
Okay, fixed the issue in the build from last comment, please try these builds |
Testing with a few videos, that build seems to have fixed it for me. Skipping works at 2x and even 3x via Enhancer for YouTube. |
Maybe you've already caught it, but I think I found the issue. Line 937 in 64ece9c
getVideo().addEventListener('ratechange', rateChangeListener) rather than () => rateChangeListener . When the event is triggered, it's currently calling (() => rateChangeListener)(event) , which just returns the rateChangeListener function rather than calling it.
It seems this was introduced in this commit which converted |
oh wow! good catch that makes sense! I'll look to see if I can get eslint to warn me about these things |
@ajayyy im having this same issue still on firefox |
Also still having this issue on the latest Firefox build. |
I have the same issue on Vivaldi, It's only working if I play the same video second times (play → stop, play → stop), but, if I swich to another video, the previous video will not skipping when I play it (need click stop → play again to make it work). |
I have this issue on brave browser on macos, thanks |
having this issue right now. |
Started having this issue on Firefox after updating to 132.0. Fully up-to-date. Youtube settings: stable audio:off, ambient mode:off, subtitles:off, playback:normal, sleep timer:off, quality:Auto(1080p60). I turned off all other add-ons and restarted Firefox so SponsorBlock is the only running add-on. It loads the blocks and shows them on the progress bar, it just doesn't skip them until I reload the page. It always fails to skip on the first load. Rewinding doesn't help, only reloading. Potential snag: I open every video by right clicking -> open link in new tab. I'll open several videos from the main or sub page this way, then watch them one at a time, closing each tab afterwards. This means they only fully load once I actually switch to the tab. The page, script, or both may not be loading as expected compared to clicking through. I have not tested just clicking through to a video because I'll never actually do that when using youtube... not since they added the miniplayer that continues playing the video after clicking back in the browser. Latter pages should never affect how a former page is presented when returning to it. |
You would probably be better off opening a new issue, whatever you're experiencing is most likely unrelated to this issue, which has already been fixed. |
What makes it seem like this issue has been fixed? I don’t use the mentioned “enhancer” and still have the issue as of last night.Thanks On Nov 17, 2024, at 1:03 PM, Hakkin Lain ***@***.***> wrote:
You would probably be better off opening a new issue, whatever you're experiencing is most likely unrelated to this issue, which has already been fixed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
I'm specifically talking about this issue ticket, the issue detailed in this ticket was fixed and closed over a year ago already, so if you're experiencing a similar issue now, it's likely unrelated to this ticket, you should open a new one with the details of your issue. The developers may not monitor issue tickets that have been closed for this long. |
I have this exact issue as well, and it only started appearing after a Firefox update. I'm assuming 132.0. |
Just started skipping for me, I use a right click open in new tab from the notification window on firefox v132.02 nix os. |
I've been noticing that SponsorBlock isn't skipping sponsored segments. When I rewind and play the video again, the sponsored segments are skipped as normal. I can't see any errors or other logs in the console. Let me know if I need to attach any logs or something similar.
P.S.: I'm also running Enhancer for Youtube, uBlock Origin and Return Youtube Dislike extensions.
The text was updated successfully, but these errors were encountered: