Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urlencoding is broken in http-client #44

Open
whotwagner opened this issue Oct 29, 2023 · 2 comments
Open

Urlencoding is broken in http-client #44

whotwagner opened this issue Oct 29, 2023 · 2 comments
Assignees
@whotwagner
Labels
bug Something isn't working

Comments

@whotwagner
Copy link
Contributor

httpx seems not to be very flexible when it comes to urlencoding. httpx will doubledecode '%' for the following url:

http://172.17.0.106/index.php?-d+allow_url_include%3don+-d+auto_prepend_file%3dphp://input
@whotwagner whotwagner added the bug Something isn't working label Oct 29, 2023
@whotwagner whotwagner self-assigned this Oct 29, 2023
@thorinaboenke
Copy link
Contributor

thorinaboenke commented Jul 30, 2024 •
edited
Loading

ToDo: Confirm if this fix to httpx encode/httpx#2990 fixes this bug

@whotwagner
Copy link
Contributor Author

You can try. Use this example playbook: https://github.com/ait-testbed/attackmate/blob/main/examples/webserv.yml and try to replace the CURL command with the builtin http-command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whotwagner whotwagner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whotwagner @thorinaboenke