Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong Git tags #460

Open
hboutemy opened this issue Aug 17, 2024 · 6 comments
Open

wrong Git tags #460

hboutemy opened this issue Aug 17, 2024 · 6 comments

Comments

@hboutemy
Copy link
Contributor

airbase is marked as successful Reproducible Builds: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/io/airlift/airbase/README.md

but if you look at buildspecs, you'll see that on each release, I need to manually get the Git commit that was used to do the release to Maven Central, because it's never the commit associated to the Git tag

it would be nice if in future releases, the Git tag was correct, please :)

@wendigo
Copy link
Contributor

wendigo commented Aug 23, 2024

This seems to be an issue with our release automation. I’ll investigate it next week

@hboutemy
Copy link
Contributor Author

@wendigo just a reminder that Git tags are still wrong, I need to adjust manually the commit id on each release

@wendigo
Copy link
Contributor

wendigo commented Sep 25, 2024

@hboutemy yes, I'm aware and I have it on my ever-growing to-do list. I'll try to tackle it next week as I need to add similar automation to other projects (trinodb/s3-proxy and gateway to name a few)

@wendigo
Copy link
Contributor

wendigo commented Sep 25, 2024

@hboutemy how about now?

@wendigo
Copy link
Contributor

wendigo commented Sep 25, 2024

nah, that doesn't work either. I don't get it why the JReleaser is creating improver tag since the HEAD points to the prepare release commit

@wendigo
Copy link
Contributor

wendigo commented Sep 25, 2024

This is jreleaser/jreleaser#1692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants