From 15d2396d35a52bdcfc4de387fe94947c2f6a73d0 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Fri, 3 Nov 2023 14:08:13 +0100 Subject: [PATCH 1/3] Add spec_migration_version to connector specification --- .../main/resources/airbyte_protocol/airbyte_protocol.yaml | 6 ++++++ .../resources/airbyte_protocol/v0/airbyte_protocol.yaml | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml index a465bcb..2cee969 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml @@ -502,6 +502,12 @@ definitions: protocol_version: description: "the Airbyte Protocol version supported by the connector. Protocol versioning uses SemVer. " type: string + spec_migration_version: + type: integer + description: |- + The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. + This allows the platform to track whether a persisted config object is up to date or not. + Specifying a version is optional, but if a version of the connector specifies it, all subsequent versions must specify it as well. The number must either be incremented or stay the same. OAuthConfigSpecification: type: object additionalProperties: true diff --git a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml index e17fc0f..3bdc691 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml @@ -553,6 +553,12 @@ definitions: protocol_version: description: "the Airbyte Protocol version supported by the connector. Protocol versioning uses SemVer. " type: string + spec_migration_version: + type: integer + description: |- + The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. + This allows the platform to track whether a persisted config object is up to date or not. + Specifying a version is optional, but if a version of the connector specifies it, all subsequent versions must specify it as well. The number must either be incremented or stay the same. OAuthConfigSpecification: type: object additionalProperties: true From 588d1120c15e823faab1ea34eeb4e334fad95d00 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Fri, 3 Nov 2023 14:19:23 +0100 Subject: [PATCH 2/3] fix yaml --- .../main/resources/airbyte_protocol/airbyte_protocol.yaml | 8 ++++---- .../resources/airbyte_protocol/v0/airbyte_protocol.yaml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml index 2cee969..87858e1 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml @@ -504,10 +504,10 @@ definitions: type: string spec_migration_version: type: integer - description: |- - The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. - This allows the platform to track whether a persisted config object is up to date or not. - Specifying a version is optional, but if a version of the connector specifies it, all subsequent versions must specify it as well. The number must either be incremented or stay the same. + description: |- + The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. + This allows the platform to track whether a persisted config object is up to date or not. + Specifying a version is optional, but if a version of the connector specifies it, all subsequent versions must specify it as well. The number must either be incremented or stay the same. OAuthConfigSpecification: type: object additionalProperties: true diff --git a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml index 3bdc691..bb03ec9 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml @@ -555,10 +555,10 @@ definitions: type: string spec_migration_version: type: integer - description: |- - The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. - This allows the platform to track whether a persisted config object is up to date or not. - Specifying a version is optional, but if a version of the connector specifies it, all subsequent versions must specify it as well. The number must either be incremented or stay the same. + description: |- + The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. + This allows the platform to track whether a persisted config object is up to date or not. + Specifying a version is optional, but if a version of the connector specifies it, all subsequent versions must specify it as well. The number must either be incremented or stay the same. OAuthConfigSpecification: type: object additionalProperties: true From 95166e9b31691f5b762a2fa4114d5d8762a5c237 Mon Sep 17 00:00:00 2001 From: Joe Reuter Date: Mon, 6 Nov 2023 10:46:54 +0100 Subject: [PATCH 3/3] adjust property name --- .../src/main/resources/airbyte_protocol/airbyte_protocol.yaml | 2 +- .../main/resources/airbyte_protocol/v0/airbyte_protocol.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml index 87858e1..0151a60 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml @@ -502,7 +502,7 @@ definitions: protocol_version: description: "the Airbyte Protocol version supported by the connector. Protocol versioning uses SemVer. " type: string - spec_migration_version: + spec_version: type: integer description: |- The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented. diff --git a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml index bb03ec9..f48f0d7 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml @@ -553,7 +553,7 @@ definitions: protocol_version: description: "the Airbyte Protocol version supported by the connector. Protocol versioning uses SemVer. " type: string - spec_migration_version: + spec_version: type: integer description: |- The version of the spec - if there is a change that requires to migrate the config of an actor, this number should be incremented.