From e62bb1ddd6f0b4973e25f4387f743159199d4fb0 Mon Sep 17 00:00:00 2001 From: Geronimo Mendez <113253381+Geromendez135@users.noreply.github.com> Date: Tue, 23 Jul 2024 14:17:46 -0300 Subject: [PATCH] Support for `Ruby 3.3` (#205) # NEW * added support for ruby 3.3 # CHANGED * increased the minimum rubocop version to ~> 1.61 (from ~> 1.32.0) -- **potentially breaking** # BREAKING * drop support for ruby 2.6 --- .github/workflows/rspec_rubocop.yml | 6 +++--- rubocop-airbnb/config/rubocop-style.yml | 4 ++-- rubocop-airbnb/rubocop-airbnb.gemspec | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/rspec_rubocop.yml b/.github/workflows/rspec_rubocop.yml index 107aa7c..bbad1f1 100644 --- a/.github/workflows/rspec_rubocop.yml +++ b/.github/workflows/rspec_rubocop.yml @@ -18,18 +18,18 @@ jobs: strategy: matrix: include: # use bundler 2.3 for ruby versions < 2.6 (https://bundler.io/compatibility.html) - - ruby-version: '2.6' - bundler-version: latest - ruby-version: '2.7' bundler-version: latest - ruby-version: '3.0' bundler-version: latest - ruby-version: '3.1' bundler-version: latest + - ruby-version: '3.3' + bundler-version: latest steps: - uses: actions/checkout@v3 - name: Set up Ruby - uses: ruby/setup-ruby@ee2113536afb7f793eed4ce60e8d3b26db912da4 # v1.127.0 + uses: ruby/setup-ruby@2a9a743e19810b9f3c38060637daf594dbd7b37f # 1.186.0 with: ruby-version: ${{ matrix.ruby-version }} bundler: ${{ matrix.bundler-version }} diff --git a/rubocop-airbnb/config/rubocop-style.yml b/rubocop-airbnb/config/rubocop-style.yml index 4e8c516..d81ce16 100644 --- a/rubocop-airbnb/config/rubocop-style.yml +++ b/rubocop-airbnb/config/rubocop-style.yml @@ -116,7 +116,7 @@ Style/BlockDelimiters: - let! - subject - watch - IgnoredMethods: + AllowedMethods: # Methods that can be either procedural or functional and cannot be # categorised from their usage alone, e.g. # @@ -889,7 +889,7 @@ Style/SymbolLiteral: Style/SymbolProc: Description: Use symbols as procs instead of blocks when possible. Enabled: false - IgnoredMethods: + AllowedMethods: - respond_to Style/TernaryParentheses: diff --git a/rubocop-airbnb/rubocop-airbnb.gemspec b/rubocop-airbnb/rubocop-airbnb.gemspec index 07612f3..f68f14a 100644 --- a/rubocop-airbnb/rubocop-airbnb.gemspec +++ b/rubocop-airbnb/rubocop-airbnb.gemspec @@ -15,7 +15,7 @@ Gem::Specification.new do |spec| spec.license = 'MIT' spec.version = RuboCop::Airbnb::VERSION spec.platform = Gem::Platform::RUBY - spec.required_ruby_version = '>= 2.5' + spec.required_ruby_version = '>= 2.7' spec.require_paths = ['lib'] spec.files = Dir[ @@ -25,9 +25,9 @@ Gem::Specification.new do |spec| 'Gemfile', ] - spec.add_dependency('rubocop', '~> 1.32.0') - spec.add_dependency('rubocop-performance', '~> 1.10.2') - spec.add_dependency('rubocop-rails', '~> 2.9.1') - spec.add_dependency('rubocop-rspec', '~> 2.0.0') + spec.add_dependency('rubocop', '~> 1.61') + spec.add_dependency('rubocop-performance', '~> 1.20') + spec.add_dependency('rubocop-rails', '~> 2.24') + spec.add_dependency('rubocop-rspec', '~> 2.26') spec.add_development_dependency('rspec', '~> 3.5') end