[3.13 backport] Fix test_data_file race condition on Python 3.14 free-threaded#12171
Merged
Dreamsorcerer merged 1 commit intoaio-libs:3.13from Feb 28, 2026
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Member
|
It really doesn't want to checkout the repo... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.13 #12171 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 128 128
Lines 44699 44704 +5
Branches 2431 2431
=======================================
+ Hits 43932 43939 +7
+ Misses 590 589 -1
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Backport of #12170 to the
3.13release branch.This fixes a flaky test (
test_data_file) that fails on Python 3.14 free-threaded (3.14t) builds.The test asserts
asyncio.isfuture(req._writer)immediately afterawait req.send(conn). On Python 3.12+,asyncio.Taskacceptseager_start=True. Because the 2-byte file payload in the test is tiny, the task may complete synchronously duringsend(), leavingreq._writerasNone.We mock
write_bytesto executeawait asyncio.sleep(0), guaranteeing the task yields before the assertion.Are there changes in behavior for the user?
No user-facing changes. This strictly fixes test flakiness.
Is it a substantial burden for the maintainers to support this?
No. This follows the exact same pattern already used in
test_data_stream.Related issue number
Backport of #12170
Checklist
CHANGES/folder