JS heap size limit using client with client.switchUser(token) and client.destroy()

[s1ncereboy]

Hello everyone and hello aiko.

I have one issue, which I want to resolve, but I am unsure how. Hope you will give me advice.

Issue is: Every 45 min scheduler is sending messages from different clients to different channels, and every time the logic is executed, the free memory becomes less and less until 'JS Heap size error'.

I am trying to send messages via scheduler.ts from different users to different channels every 45 min:

import * as schedule from 'node-schedule';
import { initializeSettingsAndSendMessage } from './services/discordService';

async function myTask() {
  console.log('Start at ', new Date());
  await initializeSettingsAndSendMessage();
  console.log('End at ', new Date());
}

export const job = schedule.scheduleJob('*/45 * * * *', myTask);

initializeSettingsAndSendMessage() function:

try {
    const discordClient = new DiscordClient();
    //every setting contain user token
    for (const setting of settingsList) {
      const isSuccessStart = await discordClient.start(setting)
      if(!isSuccessStart) {
        continue;
      }
      await discordClient.sendMessagesDependsOnId(discordClient.getSettingId());
    }
} catch (error) {
    console.error(error);
}

I am starting a self-bot via discordClient.start(setting) method for every setting,
and perform sending messages via discordClient.sendMessagesDependsOnId(settingId).

DiscordClient class:

export class DiscordClient {
  private client: Discord.Client;
  private setting: Setting;
  
  constructor() {
      this.client = new Discord.Client({
        checkUpdate: false
      });
      this.setting = {
        id: 0,
        userId: 0,
        TOKEN: 'TOKEN',
        username: 'username'
      }
  }
  
  public async sendMessagesDependsOnId(settingId: Number) {
    if (!this.client || !this.client.user) {
      return;
    }

    const messageService = new MessageService(new Database(databasePath));
    const messageList: Message[] = await messageService.getEnabledMessagesBySettingId(settingId);
    messageService.close();

    for (const message of messageList) {
      const { content, guildId, channelId, files } = message;
      
      const guild = this.client.guilds.cache.get(guildId.toString());
      if (!guild) {
        continue;
      }

      const channel = guild.channels.cache.get(channelId.toString());
      if (!channel) {
        continue;
      }

      if (channel.isText()) {

        try {
          await channel.send({
            content: content,
            files: JSON.parse(files)
          })
        } catch (error: any) {
          console.error(error);
        }
      }
    }

    this.stop();
  }

  public getSettingId() {
    return this.setting.id;
  }


  public async start(setting: Setting) {
    try {
      this.setting = setting;
      await this.client.switchUser(this.setting.TOKEN);
      console.log(`Success login @${this.client.user ? this.client.user.tag : 'unknown'} with token ${this.setting.TOKEN}.`)
      return true;
    } catch (error) {
      console.log(error);
      this.stop()
    }
    return false;
  }
  public async stop() {
    try {
      await this.client.destroy();
    } catch (error) {
      console.error(error);
    }
  }

}

As you see from the code, I am using this.stop() method to destroy client. Also I am using client.switchUser() method, which login via new token and clearing cache.

After using client.switchUser() memory usage became less, but it is still not enough and I have JS heap size error.

Please, let me know what is wrong in my realization. I want to resolve issue with heap and start host my app.

[DemonMartin]

One way to at least delay this issue is by adding the --max-old-space-size=XXXX arg when starting the project using node.

The issue is that JavaScript garbage collecting doesn't seem to be correctly working, the same issue exists in the original discordJS module.

If anyone has a fix, please LMK too!

[s1ncereboy]

RAM is always increasing. So if I will increase the limit, anyway I will get JS heap size error.

[s1ncereboy]

Thank you.