forked from expressjs/compression
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete compression version history from HISTORY.md #7
Comments
mikemaccana
changed the title
Is latest version 1.6.1 or 0.1.3
Is latest version 1.6.1 or 0.1.3?
Apr 4, 2017
Thanks Mike! The 1.6.x versions are the versions of |
aickin
changed the title
Is latest version 1.6.1 or 0.1.3?
Delete compression version history from HISTORY.md
Apr 5, 2017
Since this project is mature, it could be good release a new version with a post-1.x version. 0.1.3 can seem a bit experimental. Maybe 2.0 since it's a breaking change from the old compression module?
…________________________________
From: Sasha Aickin <[email protected]>
Sent: Wednesday, April 5, 2017 11:26:30 PM
To: aickin/shrink-ray
Cc: Mike MacCana; Author
Subject: Re: [aickin/shrink-ray] Is latest version 1.6.1 or 0.1.3? (#7)
Thanks Mike!
The 1.6.x versions are the versions of compression (which this was forked from) whereas 0.1.3 is the version of this (shrink-ray). I guess I should modify HISTORY.md to reflect this project only; I'll change the title of this issue. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#7 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAKiMvdjLrziNvfdER4cKK9BS27cslw8ks5rtBUWgaJpZM4MzPpI>.
|
scttdavs
pushed a commit
to scttdavs/shrink-ray
that referenced
this issue
Nov 2, 2018
Update mocha to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This module is excellent! brotli's going, the config is intuitive, and documentation are excellent.
One minor nitpick: the version's not consistent.
According to https://github.com/aickin/shrink-ray/blob/master/HISTORY.md it's 1.6.1
According to https://www.npmjs.com/package/shrink-ray it's 0.1.3
Maybe update both and publish 1.6.2 on npm (as the module seems pretty stable now and 1.6.2 is more semver-y).
The text was updated successfully, but these errors were encountered: