Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete compression version history from HISTORY.md #7

Open
mikemaccana opened this issue Apr 4, 2017 · 2 comments
Open

Delete compression version history from HISTORY.md #7

mikemaccana opened this issue Apr 4, 2017 · 2 comments

Comments

@mikemaccana
Copy link

mikemaccana commented Apr 4, 2017

This module is excellent! brotli's going, the config is intuitive, and documentation are excellent.

One minor nitpick: the version's not consistent.

According to https://github.com/aickin/shrink-ray/blob/master/HISTORY.md it's 1.6.1

According to https://www.npmjs.com/package/shrink-ray it's 0.1.3

Maybe update both and publish 1.6.2 on npm (as the module seems pretty stable now and 1.6.2 is more semver-y).

@mikemaccana mikemaccana changed the title Is latest version 1.6.1 or 0.1.3 Is latest version 1.6.1 or 0.1.3? Apr 4, 2017
@aickin
Copy link
Owner

aickin commented Apr 5, 2017

Thanks Mike!

The 1.6.x versions are the versions of compression (which this was forked from) whereas 0.1.3 is the version of this (shrink-ray). I guess I should modify HISTORY.md to reflect this project only; I'll change the title of this issue. Thanks!

@aickin aickin changed the title Is latest version 1.6.1 or 0.1.3? Delete compression version history from HISTORY.md Apr 5, 2017
@mikemaccana
Copy link
Author

mikemaccana commented Apr 6, 2017 via email

scttdavs pushed a commit to scttdavs/shrink-ray that referenced this issue Nov 2, 2018
Update mocha to the latest version 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants