Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify debug on 304 requests #12

Open
peteruithoven opened this issue May 15, 2017 · 0 comments
Open

Clarify debug on 304 requests #12

peteruithoven opened this issue May 15, 2017 · 0 comments

Comments

@peteruithoven
Copy link

Usually when a request is successfully compressed the following is logged:

  compression br compression +0ms
GET /css/main.css 200 9.266 ms - -

But currently when a 304 request is done the following is logged:

  compression undefined not compressible +31ms
  compression no compression: filtered +0ms
GET /css/main.css 304 2.259 ms - -

When getting to know this library this was very confusion, the behaviour looks like a bug. Is there any way to clarify this?
scttdavs pushed a commit to scttdavs/shrink-ray that referenced this issue Nov 2, 2018
@Alorel
chore(package): switch to maintained fork of node-zopfli (aickin#12)
6ac571d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peteruithoven