Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fetch remote repositories repo] is missing when using gitlab #244

Open
mritd opened this issue Aug 3, 2020 · 1 comment
Open

[Fetch remote repositories repo] is missing when using gitlab #244

mritd opened this issue Aug 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@mritd
Copy link

mritd commented Aug 3, 2020

What happened:

When using gitlab, the number of repositories displayed on the UI interface is incorrect after clicking the [Fetch remote repositories repo] button

What you expected to happen:

The UI interface can correctly display the number of warehouses.

How to reproduce it (as minimally and precisely as possible):

Only need to connect to gitlab correctly, and the current user has more than 50 (not completely accurate) repositories on gitlab.

Anything else we need to know?:

After reading the source code, agloa uses github.com/xanzy/go-gitlab as the gitlab connection client; but by default go-gitlab will not handle paging, which results in repo that exceeds one page will not be displayed.

Reference source code: https://github.com/agola-io/agola/blob/master/internal/gitsources/gitlab/gitlab.go#L281

Environment:

  • Agola version: master
  • Agola running environment (if useful to understand the bug): docker
  • Others:
@mritd mritd added the bug Something isn't working label Aug 3, 2020
@sgotti
Copy link
Member

sgotti commented Aug 18, 2020

@mritd Thanks for the report! Since you've already discovered the issues, would you like to open a Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants