Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not compatible with PHP 8 #3

Open
patrickuhlmann opened this issue Apr 17, 2022 · 2 comments
Open

Not compatible with PHP 8 #3

patrickuhlmann opened this issue Apr 17, 2022 · 2 comments

Comments

@patrickuhlmann
Copy link

patrickuhlmann commented Apr 17, 2022 •
edited
Loading

The login works fine but when I try to open the account page of a user (e. g. /accounts/account/5e8c4a1f30656581770002f3). The following error can be found in the log:

[Sun Apr 17 23:22:58.845694 2022] [php:error] [pid 178415] [client 144.2.110.170:5461] PHP Fatal error:  DASPRiD\\Enum\\AbstractEnum::__sleep(): Return type must be array when declared in 
/var/www/cockpit/addons/2FA/lib/DASPRiD/Enum/AbstractEnum.php on line 217, referer: ...

Additionally there are a few warnings
PHP Warning: Private methods cannot be final as they are never overridden by other classes

I think this is because of PHP 8
@patrickuhlmann
Copy link
Author

patrickuhlmann commented Apr 17, 2022 •
edited
Loading

It seems to be that issue with DASPRiD (for the warnings): DASPRiD/Enum#5

@patrickuhlmann patrickuhlmann mentioned this issue Apr 17, 2022
Closed
@patrickuhlmann
Copy link
Author

I created a pull request that solves the warning as well as the error. It just ports the fix from the used library.

This was referenced Apr 23, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrickuhlmann