Remove EndTurn

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Author: maxbrunsfeld

rust/acp_tests.rs

@@ -72,10 +72,6 @@ impl Client for TestClient {
     async fn glob_search(&self, _request: GlobSearchParams) -> Result<GlobSearchResponse> {
         Ok(GlobSearchResponse { matches: vec![] })
     }
-
-    async fn end_turn(&self, _request: EndTurnParams) -> Result<EndTurnResponse> {
-        Ok(EndTurnResponse {})
-    }
 }
 
 #[tokio::test]

rust/schema.rs

@@ -170,7 +170,6 @@ acp_peer!(
         GlobSearchParams,
         GlobSearchResponse
     ),
-    (end_turn, "endTurn", EndTurnParams, EndTurnResponse),
 );
 
 acp_peer!(
@@ -309,16 +308,6 @@ pub struct SendMessageParams {
 #[serde(rename_all = "camelCase")]
 pub struct SendMessageResponse;
 
-#[derive(Debug, Serialize, Deserialize, JsonSchema)]
-#[serde(rename_all = "camelCase")]
-pub struct EndTurnParams {
-    pub thread_id: ThreadId,
-}
-
-#[derive(Debug, Serialize, Deserialize, JsonSchema)]
-#[serde(rename_all = "camelCase")]
-pub struct EndTurnResponse;
-
 #[derive(Debug, Serialize, Deserialize, JsonSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct FileVersion(pub u64);

schema.json

@@ -69,9 +69,6 @@
         },
         {
           "$ref": "#/$defs/GlobSearchParams"
-        },
-        {
-          "$ref": "#/$defs/EndTurnParams"
         }
       ]
     },
@@ -91,9 +88,6 @@
         },
         {
           "$ref": "#/$defs/GlobSearchResponse"
-        },
-        {
-          "$ref": "#/$defs/EndTurnResponse"
         }
       ]
     },
@@ -109,18 +103,6 @@
       },
       "required": ["threadId"]
     },
-    "EndTurnParams": {
-      "type": "object",
-      "properties": {
-        "threadId": {
-          "$ref": "#/$defs/ThreadId"
-        }
-      },
-      "required": ["threadId"]
-    },
-    "EndTurnResponse": {
-      "type": "null"
-    },
     "FileVersion": {
       "type": "integer",
       "format": "uint64",

typescript/acp.test.ts

@@ -5,8 +5,6 @@ import {
   Connection,
   CreateThreadParams,
   CreateThreadResponse,
-  EndTurnParams,
-  EndTurnResponse,
   GetThreadEntriesParams,
   GetThreadEntriesResponse,
   GetThreadsParams,
@@ -316,7 +314,4 @@ class StubClient implements Client {
   globSearch(_: GlobSearchParams): Promise<GlobSearchResponse> {
     throw new Error("Method not implemented.");
   }
-  endTurn(_: EndTurnParams): Promise<EndTurnResponse> {
-    throw new Error("Method not implemented.");
-  }
 }

typescript/schema.ts

@@ -8,8 +8,7 @@ export type AnyClientRequest =
   | ReadTextFileParams
   | ReadBinaryFileParams
   | StatParams
-  | GlobSearchParams
-  | EndTurnParams;
+  | GlobSearchParams;
 export type MessageChunk = {
   type: "text";
   chunk: string;
@@ -20,11 +19,9 @@ export type AnyClientResult =
   | ReadTextFileResponse
   | ReadBinaryFileResponse
   | StatResponse
-  | GlobSearchResponse
-  | EndTurnResponse;
+  | GlobSearchResponse;
 export type StreamMessageChunkResponse = null;
 export type FileVersion = number;
-export type EndTurnResponse = null;
 export type AnyAgentRequest =
   | GetThreadsParams
   | CreateThreadParams
@@ -78,9 +75,6 @@ export interface GlobSearchParams {
   pattern: string;
   threadId: ThreadId;
 }
-export interface EndTurnParams {
-  threadId: ThreadId;
-}
 export interface ReadTextFileResponse {
   content: string;
   version: FileVersion;
@@ -133,7 +127,6 @@ export interface Client {
   readBinaryFile(params: ReadBinaryFileParams): Promise<ReadBinaryFileResponse>;
   stat(params: StatParams): Promise<StatResponse>;
   globSearch(params: GlobSearchParams): Promise<GlobSearchResponse>;
-  endTurn(params: EndTurnParams): Promise<EndTurnResponse>;
 }
 
 export const CLIENT_METHODS = new Set([
@@ -142,7 +135,6 @@ export const CLIENT_METHODS = new Set([
   "readBinaryFile",
   "stat",
   "globSearch",
-  "endTurn",
 ]);
 
 export interface Agent {