Add pushToolCall RPC method

Author: benbrandt

rust/acp_tests.rs

@@ -83,6 +83,10 @@ impl Client for TestClient {
         })
     }
 
+    async fn push_tool_call(&self, _request: PushToolCallParams) -> Result<PushToolCallResponse> {
+        Ok(PushToolCallResponse { id: ToolCallId(0) })
+    }
+
     async fn update_tool_call(
         &self,
         _request: UpdateToolCallParams,

rust/schema.rs

@@ -176,6 +176,12 @@ acp_peer!(
         RequestToolCallConfirmationParams,
         RequestToolCallConfirmationResponse
     ),
+    (
+        push_tool_call,
+        "pushToolCall",
+        PushToolCallParams,
+        PushToolCallResponse
+    ),
     (
         update_tool_call,
         "updateToolCall",
@@ -442,6 +448,20 @@ pub enum ToolCallConfirmationOutcome {
     Reject,
 }
 
+#[derive(Debug, Serialize, Deserialize, JsonSchema)]
+#[serde(rename_all = "camelCase")]
+pub struct PushToolCallParams {
+    pub thread_id: ThreadId,
+    pub title: String,
+    pub description: String,
+}
+
+#[derive(Debug, Serialize, Deserialize, JsonSchema)]
+#[serde(tag = "type", rename_all = "camelCase")]
+pub struct PushToolCallResponse {
+    pub id: ToolCallId,
+}
+
 #[derive(Clone, Debug, Serialize, Deserialize, JsonSchema, Eq, PartialEq, Hash)]
 #[serde(rename_all = "camelCase")]
 pub struct ToolCallId(pub u64);

schema.json

@@ -73,6 +73,9 @@
         {
           "$ref": "#/$defs/RequestToolCallConfirmationParams"
         },
+        {
+          "$ref": "#/$defs/PushToolCallParams"
+        },
         {
           "$ref": "#/$defs/UpdateToolCallParams"
         }
@@ -98,6 +101,9 @@
         {
           "$ref": "#/$defs/RequestToolCallConfirmationResponse"
         },
+        {
+          "$ref": "#/$defs/PushToolCallResponse"
+        },
         {
           "$ref": "#/$defs/UpdateToolCallResponse"
         }
@@ -224,6 +230,30 @@
     "OpenThreadResponse": {
       "type": "null"
     },
+    "PushToolCallParams": {
+      "type": "object",
+      "properties": {
+        "title": {
+          "type": "string"
+        },
+        "description": {
+          "type": "string"
+        },
+        "threadId": {
+          "$ref": "#/$defs/ThreadId"
+        }
+      },
+      "required": ["threadId", "title", "description"]
+    },
+    "PushToolCallResponse": {
+      "type": "object",
+      "properties": {
+        "id": {
+          "$ref": "#/$defs/ToolCallId"
+        }
+      },
+      "required": ["id"]
+    },
     "ReadBinaryFileParams": {
       "type": "object",
       "properties": {

typescript/acp.test.ts

@@ -13,6 +13,8 @@ import {
   GlobSearchResponse,
   OpenThreadParams,
   OpenThreadResponse,
+  PushToolCallParams,
+  PushToolCallResponse,
   ReadBinaryFileParams,
   ReadBinaryFileResponse,
   ReadTextFileParams,
@@ -323,6 +325,9 @@ class StubClient implements Client {
   ): Promise<RequestToolCallConfirmationResponse> {
     throw new Error("Method not implemented.");
   }
+  pushToolCall(_: PushToolCallParams): Promise<PushToolCallResponse> {
+    throw new Error("Method not implemented.");
+  }
   updateToolCall(_: UpdateToolCallParams): Promise<UpdateToolCallResponse> {
     throw new Error("Method not implemented.");
   }

typescript/schema.ts

@@ -10,6 +10,7 @@ export type AnyClientRequest =
   | StatParams
   | GlobSearchParams
   | RequestToolCallConfirmationParams
+  | PushToolCallParams
   | UpdateToolCallParams;
 export type MessageChunk = {
   type: "text";
@@ -51,6 +52,7 @@ export type AnyClientResult =
   | StatResponse
   | GlobSearchResponse
   | RequestToolCallConfirmationResponse
+  | PushToolCallResponse
   | UpdateToolCallResponse;
 export type StreamMessageChunkResponse = null;
 export type FileVersion = number;
@@ -113,6 +115,11 @@ export interface RequestToolCallConfirmationParams {
   confirmation: ToolCallConfirmation;
   threadId: ThreadId;
 }
+export interface PushToolCallParams {
+  title: string;
+  description: string;
+  threadId: ThreadId;
+}
 export interface UpdateToolCallParams {
   content: ToolCallContent | null;
   status: ToolCallStatus;
@@ -138,6 +145,9 @@ export interface RequestToolCallConfirmationResponse {
   id: ToolCallId;
   outcome: ToolCallConfirmationOutcome;
 }
+export interface PushToolCallResponse {
+  id: ToolCallId;
+}
 export interface OpenThreadParams {
   threadId: ThreadId;
 }
@@ -178,6 +188,7 @@ export interface Client {
   requestToolCallConfirmation(
     params: RequestToolCallConfirmationParams,
   ): Promise<RequestToolCallConfirmationResponse>;
+  pushToolCall(params: PushToolCallParams): Promise<PushToolCallResponse>;
   updateToolCall(params: UpdateToolCallParams): Promise<UpdateToolCallResponse>;
 }
 
@@ -188,6 +199,7 @@ export const CLIENT_METHODS = new Set([
   "stat",
   "globSearch",
   "requestToolCallConfirmation",
+  "pushToolCall",
   "updateToolCall",
 ]);