Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration files saved without formatting values #5

Open
afdaniele opened this issue Jul 19, 2018 · 0 comments
Open

configuration files saved without formatting values #5

afdaniele opened this issue Jul 19, 2018 · 0 comments
Assignees
Labels

Comments

@afdaniele
Copy link
Owner

afdaniele commented Jul 19, 2018

The configuration file for the core package (and I guess the others packages too) are dumped with the values not formatted according to the metadata of the configuration.

For instance, the file metadata.json of the configuration for the core package reads:

{
    "configuration_content" : {
        "maintenance_mode" : {
            "title" : "Mainteinance mode (NOT YET IMPLEMENTED)",
            "type" : "boolean",
            "default" : false,
            "details" : "Whether the platform is in maintenance mode"
        },
        . . .
    }
}

whereas after pushing a new configuration from the browser, this is what the file configuration.json looks like:

{
	"maintenance_mode": "1",
	"navbar_title": "Welcome",
	"logo_white": "http:\/\/compose.afdaniele.com\/images\/compose-white-logo.svg",
	"logo_black": "http:\/\/compose.afdaniele.com\/images\/compose-black-logo.svg",
	"admin_contact_email_address": "[email protected]",
	"cache_enabled": "0",
	"guest_default_page": "login",
	"user_default_page": "profile",
	"supervisor_default_page": "profile",
	"administrator_default_page": "profile"
}

It is clear that maintenance_mode should be formatted to be true rather than 1.

@afdaniele afdaniele added the bug label Jul 19, 2018
@afdaniele afdaniele self-assigned this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant