Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joint significant test #27

Open
Shunsenhuang-123 opened this issue Nov 29, 2020 · 1 comment
Open

joint significant test #27

Shunsenhuang-123 opened this issue Nov 29, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Shunsenhuang-123
Copy link

  • Specification Curve version:
  • Python version:
  • Operating System:

Description

Dear aeturrell,
Is there any functions which may help to conduct "joint significance test" in this packages?
And is there any document that help to discribe the uses of each function?
Thank you!

What I Did

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.
@aeturrell
Copy link
Owner

Thanks for submitting the first non-author issue for specification curve! 🎉

  1. I think adding the results of an F-statistic somewhere make sense. Definitely it should be in the dataframe of results that is created when you perform fit, eg
sc.fit()
sc.df_r

with df_r including an F statistic for each specification. But would it add value to have it displayed in the plots somewhere too? If you can give an example of what the functionality is that you'd like to see, that would be really helpful.

  1. Unfortunately the documentation is a work in progress that I can only return to in dribs and drabs when I have time.. I'd be delighted to get pull requests that added doc strings or better documentation (see the contribution guidelines for how to do this). However, if there's a specific part of the documentation that you need better clarity on, please let me know and I will ensure that it is addressed first.

@aeturrell aeturrell added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants