Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do you think about the inclusion of basic Kanji in future versions? #7

Open
aeri opened this issue May 5, 2020 · 7 comments
Open
Labels
question Further information is requested

Comments

@aeri
Copy link
Owner

aeri commented May 5, 2020

I think it might be interesting to include the most basic Kanji such as numbers or the most common ones.

@aeri aeri added the question Further information is requested label May 5, 2020
@seniorm0ment
Copy link

Would be ok with this

@yusdacra
Copy link

yusdacra commented Sep 5, 2020

I would love this, and could make a PR for it. Would be good to choose exactly what we will include though.

@aeri
Copy link
Owner Author

aeri commented Sep 6, 2020

@yusdacra Thank you very much for your interest, I had thought of including basic Kanki, like the ones shown here, and they are the ones needed for the N5 level.

The question I have is whether given the character of the application the correct answer should be the meaning in English, or accept both Kun'yomi and On'yomi readings. What do you think?

@yusdacra
Copy link

yusdacra commented Sep 7, 2020

I think it would be better if the user could configure what it accepts. By default it should accept both readings, but if the user wants to practice only Kun`yomi they should be able to choose so, or if the user wants to only practice the English meaning, they should be able to choose so.

@aeri
Copy link
Owner Author

aeri commented Sep 14, 2020

This could imply a big change in the core of the quiz, with the issue of literal translation still being a problem to link it to a specific language, more so now when I want to touch on the issue of internationalization. #14 It needs to be looked at.

@aeri
Copy link
Owner Author

aeri commented Sep 21, 2020

I have thought of a way to be able to implement it, once Kanji is selected, through a menu similar to the selection of the set of kanas, select which will be the correct answer to the Kanji. Another doubt I have is whether to allow the coexistence between Kana and Kanji, I would like to make another visual table in which all the Kanji would come out. How do you see it?

@yusdacra
Copy link

yusdacra commented Oct 4, 2020

I don't think we should allow practicing Kana and Kanji at the same time, since they are both different things. I think it should go like this:

  • User opens the app, greeted with a selection between Kana or Kanji
  • User selects Kanji
  • User now sees Kanji sets: numbers etc. and selects some or all of them, and starts practicing
  • User is now at the practice screen which should be like the Kana practice screen, with a visual table button that should show all the Kanji, and the statistics button

I'm a bit busy nowadays so sorry for the late reply :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants