-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for releaseServerUrl #70
Merged
Merged
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8511b07
Create fix for Add GitHub Enterprise Server support #42
jhutchings1 a0a4b55
Tweak GHES fix
jhutchings1 a0e040f
Tweak GHES fix to make it off by default
jhutchings1 01216ee
Add debugging
jhutchings1 9ff0000
Add debugging
jhutchings1 0f2d542
Rebuild dist
jhutchings1 9b4a818
Change octokit from Actions specific one to generic one
jhutchings1 61b2daa
Rebuild dist
jhutchings1 5787da5
Add fetch
jhutchings1 723a111
Rebuild dist
jhutchings1 cff2be1
Add debugging
jhutchings1 6130522
Add debugging
jhutchings1 b241c92
Rebuild dist
jhutchings1 6b81b8e
Change from convenience method to rest command
jhutchings1 8ad6ba7
Clean up code
jhutchings1 472123c
Update docs
jhutchings1 ecb240e
Merge remote-tracking branch 'origin/main' into ghes-fix
juxtin 2857c71
Fix tests by using jest-babel
juxtin 32b6a8b
Remove configuration option and automatically use the right value
juxtin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
presets: [ | ||
['@babel/preset-env', { targets: { node: 'current' } }], | ||
'@babel/preset-typescript', | ||
], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is a bit confusing to me: Does it mean that
https://api.github.com
is the default value, in which case we should change the wording. I don't think it does now that I looked at the code.Otherwise, if it means that
https://api.github.com
is the only possible valid value, then we should probably hardcode the url and use a boolean instead to trigger that option.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that is confusing. Let me figure that out and update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see what the original intent was and I rewrote it so that it should work without setting any configuration options. I'm going to try to test this in a real GHES instance to make sure.