Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPM is incorrectly using HTTP post to download the DB file #19

Open
ghost opened this issue Sep 21, 2013 · 1 comment · May be fixed by #28
Open

UPM is incorrectly using HTTP post to download the DB file #19

ghost opened this issue Sep 21, 2013 · 1 comment · May be fixed by #28

Comments

@ghost
Copy link

ghost commented Sep 21, 2013

According to the W3C specification, POST is used for making changes on the server, not for fetching content (especially static content). UPM is incorrectly using POST to try to fetch the initial DB download, which is causing failures for web servers which (correctly) disallow POST for fetching static content (such as nginx).

UPM Android should use GET to fetch static content.
@adrian
Copy link
Owner

adrian commented Sep 23, 2013

Bug confirmed. Thanks for that.

val-kulkov pushed a commit to val-kulkov/upm-android that referenced this issue Jun 12, 2016
Use HTTP GET to download the db file and patch up multipart POST syntax
14fca7f 
The proposed changes fix adrian#19 issue, enabling the use
of HTTP GET method instead of static HTTP POST to download the database
file.

The use of LF (instead of CRLF) confuses CGI.pm if CGI.pm is used to
process HTTP uploads. The proposed changes enable processing of HTTP
uploads by a custom CGI script in addition to, or as a replacement of,
the current PHP scripts.
@val-kulkov val-kulkov linked a pull request Jun 12, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use HTTP GET to download the db file and patch up multipart POST syntax val-kulkov/upm-android
1 participant
@adrian