From e7344099d9ec5a611c632e68c25d07913b7892c9 Mon Sep 17 00:00:00 2001 From: forkimenjeckayang Date: Tue, 30 Jul 2024 11:53:36 +0100 Subject: [PATCH 1/4] Modified checkstyle rules --- checkstyle.xml | 107 ++++++++++++++++++++++++++----------------------- 1 file changed, 56 insertions(+), 51 deletions(-) diff --git a/checkstyle.xml b/checkstyle.xml index b2e6fa633..41a571168 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -1,7 +1,7 @@ + "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" + "https://checkstyle.org/dtds/configuration_1_3.dtd"> + + + + + @@ -32,7 +37,7 @@ + default="checkstyle-suppressions.xml" /> @@ -44,9 +49,9 @@ - + + value="^package.*|^import.*|href\s*=\s*"[^"]*"|http://|https://|ftp://"/> @@ -54,9 +59,9 @@ + value="\\u00(09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/> + value="Consider using special escape sequence instead of octal value or Unicode escaped value."/> @@ -71,15 +76,15 @@ + value="LITERAL_IF, LITERAL_ELSE"/> + value="LITERAL_DO, LITERAL_ELSE, LITERAL_FOR, LITERAL_IF, LITERAL_WHILE"/> @@ -87,14 +92,14 @@ @@ -106,7 +111,7 @@ @@ -118,17 +123,17 @@ + value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/> @@ -139,7 +144,7 @@ @@ -174,48 +179,48 @@ + value="Package name ''{0}'' must match pattern ''{1}''."/> + value="Type name ''{0}'' must match pattern ''{1}''."/> + value="Member name ''{0}'' must match pattern ''{1}''."/> + value="Parameter name ''{0}'' must match pattern ''{1}''."/> + value="Lambda parameter name ''{0}'' must match pattern ''{1}''."/> + value="Catch parameter name ''{0}'' must match pattern ''{1}''."/> + value="Local variable name ''{0}'' must match pattern ''{1}''."/> + value="Pattern variable name ''{0}'' must match pattern ''{1}''."/> + value="Class type name ''{0}'' must match pattern ''{1}''."/> @@ -230,37 +235,37 @@ + value="Method type name ''{0}'' must match pattern ''{1}''."/> + value="Interface type name ''{0}'' must match pattern ''{1}''."/> + value="GenericWhitespace ''{0}'' is followed by whitespace."/> + value="GenericWhitespace ''{0}'' is preceded with whitespace."/> + value="GenericWhitespace ''{0}'' should followed by whitespace."/> + value="GenericWhitespace ''{0}'' is not preceded with whitespace."/> - - - - - - + + + + + + @@ -270,24 +275,24 @@ - + @@ -295,14 +300,14 @@ @@ -315,14 +320,14 @@ + value="^@return the *|^This method returns |^A [{]@code [a-zA-Z0-9]+[}]( is a )"/> - + + value="CLASS_DEF, INTERFACE_DEF, ENUM_DEF, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"/> @@ -348,7 +353,7 @@ + value="Method name ''{0}'' must match pattern ''{1}''."/> @@ -360,7 +365,7 @@ + default="checkstyle-xpath-suppressions.xml" /> @@ -377,4 +382,4 @@ - \ No newline at end of file + From 182a7b000850b0a4c3bf6787677fc7ad2caf9a54 Mon Sep 17 00:00:00 2001 From: forkimenjeckayang Date: Tue, 30 Jul 2024 11:54:37 +0100 Subject: [PATCH 2/4] Added suppression.xml to supress unnecessary checkstyle warnings --- suppression.xml | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 suppression.xml diff --git a/suppression.xml b/suppression.xml new file mode 100644 index 000000000..74642dd49 --- /dev/null +++ b/suppression.xml @@ -0,0 +1,12 @@ + + + + + + + + From 7cb197d7a24cddc2b3a3044035f1adee6b512c4e Mon Sep 17 00:00:00 2001 From: forkimenjeckayang Date: Mon, 5 Aug 2024 10:23:15 +0100 Subject: [PATCH 3/4] modified pom.xml --- pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 0b87ab326..6e7ebf073 100644 --- a/pom.xml +++ b/pom.xml @@ -371,7 +371,7 @@ checkstyle.xml true UTF-8 - true + false false false org.checkstyle.google.severity=warning @@ -403,7 +403,6 @@ Max Low - true false true true From 5274115e8e063045754984a467504b30863e500f Mon Sep 17 00:00:00 2001 From: forkimenjeckayang Date: Tue, 6 Aug 2024 11:36:39 +0100 Subject: [PATCH 4/4] Modified checkstyle and removed rules for checks not really necessary --- checkstyle.xml | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/checkstyle.xml b/checkstyle.xml index 41a571168..89b2b21d5 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -261,14 +261,6 @@ - - - - - @@ -297,13 +289,6 @@ METHOD_DEF, QUESTION, RESOURCE_SPECIFICATION, SUPER_CTOR_CALL, LAMBDA, RECORD_DEF"/> - - - - - - - - - - - @@ -336,20 +313,6 @@ - - - - - - - - - - -